Created attachment 152377 [details] steps followed for receiving an order The acquisition module, the system failed to save the barcode at the time of receiving items in an order. Clicking on confirmation and finishing the receipt while cataloguing showing Holding 0 though in the acquisition details button it is showing received 1 copy.
In your PDF, the actual receive form is missing, also the basket summary page. On the receive form, do you have the item form on the left? Koha can create items in acq on ordering, on receiving or not at all. It depends on your setting for each basket. So copies don't need to be linked to items.
Yes... at the time of receiving all data are showing perfectly including currency and the right side barcode, but after confirmation, in the summery showing the item under Already received (as shown in the attached file) but without the barcodes which I had assigned at the time of receiving the copies.
Do you see the item form or where do you enter the barcode?
Created attachment 152383 [details] All steps
Submitted new attachments showing the setup at AcqCreateItem - receiving an order in Global preference and order receiving worksheet
Hi Ranjan, thanks a lot for providing the updated document. I can confirm that adding items on receive in master and 23.05 is broken. I am updating this bug to high severity. Testing notes: * Create a basket with 'create items on receive' * Create an order line * Close basket * Receive shipment * Enter invoice number * Click on Receive link in the table * Fill out item form, make sure all mandatory fields are set * Save * Verify that the order line is marked as 'received' * Verify that there has been no item created on the record
Thanks Katrin Fischer I am perfect with all this steps. Only problem is on clicking on the Confirmation button, the barcode is not saving and showing holding as zero.
*** Bug 34057 has been marked as a duplicate of this bug. ***
blocker is worse than critical ;)
Hope the community is working on this for solving the problem quickly.
*** Bug 34046 has been marked as a duplicate of this bug. ***
Today I have observed that, on receiving, the system is not showing any result at the bottom immediately. Just after refresh, the result is coming. I have tested with one record, tried to give the barcode by edit item option from catalogue module, KOHA failed to carry the Item wise Price, and vendor information from acqusition.
(In reply to Ranjan from comment #12) > Today I have observed that, on receiving, the system is not showing any > result at the bottom immediately. Just after refresh, the result is coming. > I have tested with one record, tried to give the barcode by edit item option > from catalogue module, KOHA failed to carry the Item wise Price, and vendor > information from acqusition. There is a separate bug for this already:
(In reply to Katrin Fischer from comment #13) > (In reply to Ranjan from comment #12) > > Today I have observed that, on receiving, the system is not showing any > > result at the bottom immediately. Just after refresh, the result is coming. > > I have tested with one record, tried to give the barcode by edit item option > > from catalogue module, KOHA failed to carry the Item wise Price, and vendor > > information from acqusition. > > There is a separate bug for this already: Bug 34036 - Single receive doesn't reload data and order lines appears as pending
Created attachment 152581 [details] [review] Bug 34022: Adjust items data structure When creating items at receiving, the generated data structure didn't match what the code expected, so this patch adapts the code to match the new data structure introduced by bug 8179. Once I fixed that, I noticed that the $.ajax request payload, when it contains an array parameter, it renames it like `param[]`. So the finishreceive.pl controller is adjusted to this behaviour for the 'on receiving' use case. To test: 1. Apply this patch 2. Create a basket with 'create items on receive' 3. Create an order line 4. Close basket 5. Receive shipment 6. Enter invoice number 7. Click on Receive link in the table 8. Fill out item form, make sure all mandatory fields are set 9. Save 10. Verify that the order line is marked as 'received' 11. Verify that there item is created on the record => SUCCESS: Works as expected 12. Sign off :-D
Created attachment 152612 [details] [review] Bug 34022: Adjust items data structure When creating items at receiving, the generated data structure didn't match what the code expected, so this patch adapts the code to match the new data structure introduced by bug 8179. Once I fixed that, I noticed that the $.ajax request payload, when it contains an array parameter, it renames it like `param[]`. So the finishreceive.pl controller is adjusted to this behaviour for the 'on receiving' use case. To test: 1. Apply this patch 2. Create a basket with 'create items on receive' 3. Create an order line 4. Close basket 5. Receive shipment 6. Enter invoice number 7. Click on Receive link in the table 8. Fill out item form, make sure all mandatory fields are set 9. Save 10. Verify that the order line is marked as 'received' 11. Verify that there item is created on the record => SUCCESS: Works as expected 12. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Thanks Michaela! Starting QA, but if someone else wants to have a look, the more eyes the better.
Created attachment 152619 [details] [review] Bug 34022: Adjust items data structure When creating items at receiving, the generated data structure didn't match what the code expected, so this patch adapts the code to match the new data structure introduced by bug 8179. Once I fixed that, I noticed that the $.ajax request payload, when it contains an array parameter, it renames it like `param[]`. So the finishreceive.pl controller is adjusted to this behaviour for the 'on receiving' use case. To test: 1. Apply this patch 2. Create a basket with 'create items on receive' 3. Create an order line 4. Close basket 5. Receive shipment 6. Enter invoice number 7. Click on Receive link in the table 8. Fill out item form, make sure all mandatory fields are set 9. Save 10. Verify that the order line is marked as 'received' 11. Verify that there item is created on the record => SUCCESS: Works as expected 12. Sign off :-D Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
I've tested the various workflows (in cataloging, on order, on receive) with single and multiple items. Found 2 more bugs in the process: Bug 34109 - When adding items on receive, mandatory fields are not checked (major) Bug 34108 - When items are added on receive, item selection gets lost on editing items (normal) Also noticed this one again, it also needs an urgent fix: Bug 34036 - Single receive doesn't reload data and order lines appears as pending
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.01
Not backporting to 22.11.x, missing dependency 8719
No updates to the Koha Manual needed. Moving this to Resolved.