If I set OPAC item level holds to "force" in Circulation and Fine rules, when I go to place a hold in the OPAC I'm still given the option of choosing "next available." git bisect says the cause is Bug 24860: "Add ability to select an item group when placing a hold - OPAC"
Created attachment 153532 [details] [review] Bug 34155: Hide 'Next available' at OPAC when item-level hold is forced This was a regression caused by bug 24860 Test plan: 1. Set up circulation rules so that OPAC users can place holds only on specific items ("OPAC item level holds" = "force") 2. Try to place a hold at OPAC. The "Next available item" option should not appear. 3. Set "OPAC item level holds" to "allow" 4. Try to place a hold at OPAC. The "Next available item" option should appear
Created attachment 153537 [details] [review] Bug 34155: Hide 'Next available' at OPAC when item-level hold is forced This was a regression caused by bug 24860 Test plan: 1. Set up circulation rules so that OPAC users can place holds only on specific items ("OPAC item level holds" = "force") 2. Try to place a hold at OPAC. The "Next available item" option should not appear. 3. Set "OPAC item level holds" to "allow" 4. Try to place a hold at OPAC. The "Next available item" option should appear Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Isn't there a flaw in the controller as well? See bug 24860 comment 231.
(In reply to Jonathan Druart from comment #3) > Isn't there a flaw in the controller as well? See bug 24860 comment 231. Indeed. In my opinion we should use only 'bibitemloo.forced_hold_level' in TT if possible. bibitemloo.force_hold is not very explicit.
Created attachment 154059 [details] [review] Bug 34155: Hide 'Next available' at OPAC when item-level hold is forced This was a regression caused by bug 24860 Test plan: 1. Set up circulation rules so that OPAC users can place holds only on specific items ("OPAC item level holds" = "force") 2. Try to place a hold at OPAC. The "Next available item" option should not appear. 3. Set "OPAC item level holds" to "allow" 4. Try to place a hold at OPAC. The "Next available item" option should appear Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Fridolin Somers from comment #4) > (In reply to Jonathan Druart from comment #3) > > Isn't there a flaw in the controller as well? See bug 24860 comment 231. > > Indeed. > > In my opinion we should use only 'bibitemloo.forced_hold_level' in TT if > possible. > bibitemloo.force_hold is not very explicit. This patch works for now, but I am all for fixing it up at a higher level too. Maybe we can compromise to do that on a separate bug? Unless someone wants to do a quick bugfix here? We left this unfixed for a month now, that's not good for this type of bug.
(In reply to Katrin Fischer from comment #6) > Unless someone wants to do a quick bugfix here? We left this unfixed for a > month now, that's not good for this type of bug. Backporting bad bugfixes is worst. Code in the controller must be cleaned before push in my opinion.
(In reply to Jonathan Druart from comment #7) > (In reply to Katrin Fischer from comment #6) > > Unless someone wants to do a quick bugfix here? We left this unfixed for a > > month now, that's not good for this type of bug. > > Backporting bad bugfixes is worst. Code in the controller must be cleaned > before push in my opinion. So we just keep it broken, because noone is going to write that fix apparently? This was filed a month ago, is a user facing issue in stable releases. The patch is really small, it will be quite easy to do a proper fix on top.
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.03
Nice work everyone! Pushed to 22.11.x for next release