While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Record matching rules page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add record matching rule' to 'New record matching rule' - Add rule code in single quotes to 'Modify record matching rule' Breadcrumb - Change 'Add record matching rule' to 'New record matching rule' - Add rule code in single quotes to 'Modify record matching rule' Page header - Change 'Add record matching rule' to 'New record matching rule' - Add rule code in single quotes to 'Modify record matching rule'
Created attachment 156509 [details] [review] Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks.
Testing on 02/11/23: - Administration -> Record matching rules - New record matching rule Title - good Heading - good Breadcrumbs - good - Edit record matching rule Heading - good Breadcrumbs - good - Delete record matching rule Heading - good Breadcrumbs - good - Test the process of adding new match points and new match checks, and removing match points and match checks. I don't know if this is an issue, but when you add a new match check or point, remove it and then add another it adds "2" then when you remove 2, it adds "3" instead of another 2, even though you didn't save the original "2".
Created attachment 159505 [details] [review] Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. Signed-off-by: David Nind <david@davidnind.com>
(In reply to Katy Maydon from comment #2) > Testing on 02/11/23: > ... > I don't know if this is an issue, but when you add a new match check or > point, remove it and then add another it adds "2" then when you remove 2, it > adds "3" instead of another 2, even though you didn't save the original "2". Hi Katy. It does this before the patch, so I think that would be a separate bug. David
Created attachment 159692 [details] [review] Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 159693 [details] [review] Bug 34398: (QA follow-up): add missing |
Much cleaner, looks great :) Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.01
Merge conflicts with 23.05.x, no backport. If needed please rebase.