While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Currencies and exchange rates page, here is what should be changed to make it consistent with the other pages in the module: Page title - Remove last level. There is no option to change only the exchange rates, so there is no need to specify we are in Currencies > Currencies and exchange rates. Breadcrumb - In the deletion confirmation page, the currency code is bold, change to regular weight and add single quotes Page header - The styling of the header of the 'New currency' page is different from the rest - The styling of the header of the 'Modify currency' page is different from the rest - Add the currency code, in single quotes, in the Modify header ('Modify currency' -> "Modify currency 'ISO'") - In the deletion confirmation page, add single quote around the currency code
Created attachment 155228 [details] [review] Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header This patch updates the currencies administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. To test, apply the patch and go to Administration -> Currencies and exchange rates. Test each variation of the page to confirm that the title, breadcrumbs, and headings are consistent. - Currencies main page - New currency - Edit currency - Delete currency confirmation
Created attachment 155249 [details] [review] Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header This patch updates the currencies administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. To test, apply the patch and go to Administration -> Currencies and exchange rates. Test each variation of the page to confirm that the title, breadcrumbs, and headings are consistent. - Currencies main page - New currency - Edit currency - Delete currency confirmation Signed-off-by: David Cook <dcook@prosentient.com.au>
Created attachment 155387 [details] [review] Bug 34403: Inconsistencies in Currencies and exchange rates page titles, breadcrumbs, and header This patch updates the currencies administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. To test, apply the patch and go to Administration -> Currencies and exchange rates. Test each variation of the page to confirm that the title, breadcrumbs, and headings are consistent. - Currencies main page - New currency - Edit currency - Delete currency confirmation Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Like others, not backported to 23.05.x