While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Z39.50 servers page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add server code in single quotes to Modify Z39.50 server - Add server code in single quotes to Modify SRU server Breadcrumb - Add single quotes around server code in Modify Z39.50 server - Add single quotes around server code in Modify SRU server Page header - Remove 'administration' (change 'Z39.50/SRU servers administration' to 'Z39.50/SRU servers') - Add server code in single quotes to Modify Z39.50 server - Add server code in single quotes to Modify SRU server No special page when deleting a server, simply a browser prompt.
While reviewing the pages modified by 33909, I noticed I hadn't specifically checked sru_modmapping.tt and sru_modmapping_auth.tt Page title - Administration level missing Page header - Page headers don't usually start with verbs. Maybe change to 'SRU search fields mapping for {type} records' and add a sentence underneath to specify this form is used to modify the mappings? I'm not married to that... I'm only mentioning it.
Created attachment 155339 [details] [review] Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header This patch makes changes to the Z39.50 servers administration and related templates in order to make them more consistent with other pages in Koha. One case has been added to page title and breadcrumb navigation: An indication that a search has been performed. The subheading is modified to make it clear that the search is a "starts with" search. To test, apply the patch and go to Administration -> Z39.50/SRU servers. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - Z39.50/SRU servers list. - New Z39.50 server - New SRU server - Edit Z39.50 server - Edit SRU server - Modify SRU search field mapping for a bibliographic record server - Modify SRU search field mapping for an authority record server - Use the header search form to search for a server by name
Created attachment 155494 [details] [review] Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header This patch makes changes to the Z39.50 servers administration and related templates in order to make them more consistent with other pages in Koha. One case has been added to page title and breadcrumb navigation: An indication that a search has been performed. The subheading is modified to make it clear that the search is a "starts with" search. To test, apply the patch and go to Administration -> Z39.50/SRU servers. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - Z39.50/SRU servers list. - New Z39.50 server - New SRU server - Edit Z39.50 server - Edit SRU server - Modify SRU search field mapping for a bibliographic record server - Modify SRU search field mapping for an authority record server - Use the header search form to search for a server by name Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Created attachment 155743 [details] [review] Bug 34407: Inconsistencies in Z39.50 servers page titles, breadcrumbs, and header This patch makes changes to the Z39.50 servers administration and related templates in order to make them more consistent with other pages in Koha. One case has been added to page title and breadcrumb navigation: An indication that a search has been performed. The subheading is modified to make it clear that the search is a "starts with" search. To test, apply the patch and go to Administration -> Z39.50/SRU servers. View each variation of the page to confirm that breadcrumb navigation, page title, and page headings are consistent with each other. - Z39.50/SRU servers list. - New Z39.50 server - New SRU server - Edit Z39.50 server - Edit SRU server - Modify SRU search field mapping for a bibliographic record server - Modify SRU search field mapping for an authority record server - Use the header search form to search for a server by name Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Like others, not pushed to 23.05.x