Bug 34481 - Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches
Summary: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-04 19:32 UTC by Fridolin Somers
Modified: 2024-04-02 09:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 34481: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches (9.07 KB, patch)
2024-03-19 15:39 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34481: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches (9.06 KB, patch)
2024-04-02 07:44 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 34481: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches (9.20 KB, patch)
2024-04-02 09:07 UTC, Frédéric Demians
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2023-08-04 19:32:50 UTC
Like IncludeSeeFromInSearches adds see from heading in search (4xx), add a system preference IncludeSeeAlsoFromInSearches to add see also from heading (5xx).
Comment 1 Fridolin Somers 2024-03-19 15:39:23 UTC
Created attachment 163456 [details] [review]
Bug 34481: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches

Like IncludeSeeFromInSearches adds see from heading in search (4xx),
new system preference IncludeSeeAlsoFromInSearches adds see also from heading (5xx).

Test plan:
Test on both Elasticsearch and Zebra:
1)
1.1) Create an authority record with heading, see from heading 4xx and see also from heading 5xx
1.2) Use this authority in a biblio record
2)
2.1) Set IncludeSeeFromInSearches and IncludeSeeAlsoFromInSearches to "Don't include"
2.3) Rebuild search engine
2.4) Perform a search on heading text => you find the biblio record
2.5) Perform a search on see from heading => you do not find the biblio record
2.6) Perform a search on see also from heading => you do not find the biblio record
3)
3.1) Set IncludeSeeFromInSearches and IncludeSeeAlsoFromInSearches to "Include"
3.2) Rebuild search engine
3.3) Perform a search on heading text => you find the biblio record
3.4) Perform a search on see from heading => you find the biblio record
3.5) Perform a search on see also from heading => you find the biblio record
Comment 2 Frédéric Demians 2024-03-29 16:56:23 UTC
This line:
my $marc_filter = Koha::Koha::Filter::MARC::EmbedSeeFromHeadings->new;

should be:
my $marc_filter = Koha::Filter::MARC::EmbedSeeFromHeadings->new;

Otherwise, all good! Do I fix it directly while signing?
Comment 3 Fridolin Somers 2024-04-02 07:09:42 UTC
Ah no I will fix
Comment 4 Fridolin Somers 2024-04-02 07:44:22 UTC
Created attachment 164236 [details] [review]
Bug 34481: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches

Like IncludeSeeFromInSearches adds see from heading in search (4xx),
new system preference IncludeSeeAlsoFromInSearches adds see also from heading (5xx).

Test plan:
Test on both Elasticsearch and Zebra:
1)
1.1) Create an authority record with heading, see from heading 4xx and see also from heading 5xx
1.2) Use this authority in a biblio record
2)
2.1) Set IncludeSeeFromInSearches and IncludeSeeAlsoFromInSearches to "Don't include"
2.3) Rebuild search engine
2.4) Perform a search on heading text => you find the biblio record
2.5) Perform a search on see from heading => you do not find the biblio record
2.6) Perform a search on see also from heading => you do not find the biblio record
3)
3.1) Set IncludeSeeFromInSearches and IncludeSeeAlsoFromInSearches to "Include"
3.2) Rebuild search engine
3.3) Perform a search on heading text => you find the biblio record
3.4) Perform a search on see from heading => you find the biblio record
3.5) Perform a search on see also from heading => you find the biblio record
Comment 5 Fridolin Somers 2024-04-02 07:44:48 UTC
(In reply to Fridolin Somers from comment #3)
> Ah no I will fix

Fixed ;)
Comment 6 Frédéric Demians 2024-04-02 09:07:56 UTC
Created attachment 164246 [details] [review]
Bug 34481: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches

Like IncludeSeeFromInSearches adds see from heading in search (4xx),
new system preference IncludeSeeAlsoFromInSearches adds see also from heading (5xx).

Test plan:
Test on both Elasticsearch and Zebra:
1)
1.1) Create an authority record with heading, see from heading 4xx and see also from heading 5xx
1.2) Use this authority in a biblio record
2)
2.1) Set IncludeSeeFromInSearches and IncludeSeeAlsoFromInSearches to "Don't include"
2.3) Rebuild search engine
2.4) Perform a search on heading text => you find the biblio record
2.5) Perform a search on see from heading => you do not find the biblio record
2.6) Perform a search on see also from heading => you do not find the biblio record
3)
3.1) Set IncludeSeeFromInSearches and IncludeSeeAlsoFromInSearches to "Include"
3.2) Rebuild search engine
3.3) Perform a search on heading text => you find the biblio record
3.4) Perform a search on see from heading => you find the biblio record
3.5) Perform a search on see also from heading => you find the biblio record

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>