Bug 34561 - Move IntranetReportsHomeHTML to HTML customizations
Summary: Move IntranetReportsHomeHTML to HTML customizations
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Lisette Scheer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-17 10:37 UTC by Caroline Cyr La Rose
Modified: 2025-06-25 15:25 UTC (History)
5 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations (7.82 KB, patch)
2025-06-10 14:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations (9.93 KB, patch)
2025-06-10 22:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations (9.97 KB, patch)
2025-06-25 07:25 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations (10.05 KB, patch)
2025-06-25 15:24 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 34561: (QA follow-up) Rename to StaffReportsHome to match othe html customizations (7.12 KB, patch)
2025-06-25 15:25 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-08-17 10:37:04 UTC
Bug 6419 adds some HTML customizations to the staff interface. IntranetReportsHomeHTML is still a system preference. It would be nice to move it to HTML customizations with the others.
Comment 1 Owen Leonard 2025-06-10 14:50:36 UTC Comment hidden (obsolete)
Comment 2 Lisette Scheer 2025-06-10 20:16:21 UTC
There's no db update so it doesn't move over.

Additionally, the styling is a little different and it doesn't blend in as nicely. I'm guessing that's from <div id="[% IntranetReportsHomeHTML.location | html %]" class="page-section"> and the page section is making it stand out. Not sure that's a real problem, but I know some places use this for making what looks like an additional matching list of common reports that will snow stand out. 

Should it be IntranetReportsHomeHTML or should we rename it to StaffReportsHomeHTML for current terminology + to match most of the rest of the HTML customization?
Comment 3 Owen Leonard 2025-06-10 22:53:38 UTC
Created attachment 183149 [details] [review]
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations

This patch moves the IntranetReportsHomeHTML system preference into
HTML customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the IntranetReportsHomeHTML
system preference before applying the patch. Apply the patch and run the
database update process.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from IntranetReportsHomeHTML is now stored there.
- The HTML customization entry form should offer
  IntranetReportsHomeHTML as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Edit the IntranetReportsHomeHTML HTML customization and add unique
  content to the "fr-FR" tab.

- Go to the reports home page. You should see the
  content you added to the IntranetReportsHomeHTML HTML
  customization.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "IntranetReportsHomeHTML." It should return no results.

Sponsored-by: Athens County Public Libraries
Comment 4 PTFS Europe Sandboxes 2025-06-25 07:25:48 UTC
Created attachment 183485 [details] [review]
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations

This patch moves the IntranetReportsHomeHTML system preference into
HTML customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the IntranetReportsHomeHTML
system preference before applying the patch. Apply the patch and run the
database update process.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from IntranetReportsHomeHTML is now stored there.
- The HTML customization entry form should offer
  IntranetReportsHomeHTML as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Edit the IntranetReportsHomeHTML HTML customization and add unique
  content to the "fr-FR" tab.

- Go to the reports home page. You should see the
  content you added to the IntranetReportsHomeHTML HTML
  customization.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "IntranetReportsHomeHTML." It should return no results.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Comment 5 Lisette Scheer 2025-06-25 15:23:04 UTC
This was signed off, sandboxes didn't update.
Comment 6 Lisette Scheer 2025-06-25 15:24:09 UTC
Created attachment 183512 [details] [review]
Bug 34561: Move IntranetReportsHomeHTML to HTML customizations

This patch moves the IntranetReportsHomeHTML system preference into
HTML customizations, making it possible to have language- and
library-specific content.

To test you should have some content in the IntranetReportsHomeHTML
system preference before applying the patch. Apply the patch and run the
database update process.

- In the staff client, go to Tools -> HTML customizations and verify
  that the content from IntranetReportsHomeHTML is now stored there.
- The HTML customization entry form should offer
  StaffReportsHome as a choice under "Display location."
- Update and reinstall active translations (for instance fr-FR):
  - perl misc/translator/translate update fr-FR
  - perl misc/translator/translate install fr-FR
- Enable the translation if necessary under Administration -> System
  preferences -> language.
- Edit the StaffReportsHome HTML customization and add unique
  content to the "fr-FR" tab.

- Go to the reports home page. You should see the
  content you added to the StaffReportsHome HTML
  customization.
- Switch to your updated translation and confirm that the content you
  added for your translation shows up correctly.
- Go to Administration -> System preferences and search for
  "IntranetReportsHomeHTML." It should return no results.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Ray Delahunty <lib-systems@arts.ac.uk>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 7 Lisette Scheer 2025-06-25 15:25:10 UTC
Created attachment 183513 [details] [review]
Bug 34561: (QA follow-up) Rename to StaffReportsHome to match othe html customizations

I noticed the rest of the html customizations don't have html in the option name, so I renamed for consistency.