Bug 3492 - Move hold fee setting into circulation rules
Summary: Move hold fee setting into circulation rules
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: PC All
: P3 enhancement (vote)
Assignee: Bugs List
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-03 12:59 UTC by Jane Wagner
Modified: 2023-01-07 22:48 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Hold fee setup screenshot (49.40 KB, image/jpeg)
2009-08-03 12:59 UTC, Chris Cormack
Details
Hold fee charge screenshot (12.17 KB, image/jpeg)
2009-08-03 12:59 UTC, Chris Cormack
Details
Bug 3492: Begginings of moving holds_fee rule to circulation rules (5.01 KB, patch)
2021-04-20 13:59 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:11:21 UTC


---- Reported by jwagner@ptfs.com 2009-08-03 12:59:15 ----

Created an attachment
Hold fee setup screenshot

Sponsored by East Brunswick Public Library, East Brunswick, NJ, USA.

Add an option to set a hold fee by item type, and to assess that fee when the hold is placed.  A new field in the item type table allows entry of a hold fee (separate from the existing rental fee).  A syspref will allow that hold fee to be assessed when the hold is placed.



---- Additional Comments From jwagner@ptfs.com 2009-08-03 12:59:41 ----

Created an attachment
Hold fee charge screenshot





---- Additional Comments From jwagner@ptfs.com 2010-05-12 12:43:57 ----

The fix for this bug (in ptfs-harley) can be pulled from the public git repository at http://github.com/Koha-PTFS, branch http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3492




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:11 UTC  ---

This bug was previously known as _bug_ 3492 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3492
Imported an attachment (id=1356)
Imported an attachment (id=1357)

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was kohaprogrammers@ptfs.com.
The original submitter of attachment 1356 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1357 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Paul Poulain 2011-03-22 12:43:47 UTC
patch available at: https://github.com/ptfs/Koha-PTFS
May cause problem/incompatibility with #5872.
Comment 2 Nicole C. Engard 2011-03-22 21:09:22 UTC
A patch needs to be submitted based on master for this - and either a link
right to the patch or an attached patch is necessary.

Nicole
Comment 3 Jared Camins-Esakov 2012-02-13 13:17:08 UTC
The Harley integration project has been stalled for some time.
Comment 4 Martin Renvoize 2020-04-17 13:16:01 UTC
This is still a feature request we see fairly often.. re-opening.
Comment 5 Fiona Borthwick 2020-04-17 13:32:38 UTC
This subject often comes up during system implementations - especially with our public libraries customer base.

The hold fee is currently assigned to the patron category but many libraries have varying hold fees dependent upon item type. It is often thought that it would be more useful to have the hold fee linked to the item type instead of the patron category.

For example:
Hold on Adult book by Adult user = £1.00
Hold on Junior book by Adult user = £0.50

If the hold fee in the Adult patron category is set to £1.00, then they will be charged £1.00 for every hold they place - regardless if is an adult or a junior book.

An alternative approach may be to adopt a solution similar to the 'rental fee discount' in the circulation rules. The rental fee is associated with the item type but the system administrators are able to manipulate the circ rules to allow for specific users to borrow items with rental fees at a reduced rate.
Comment 6 Katrin Fischer 2020-04-18 03:54:18 UTC
Maybe we should just move it to the circulation rules?

I think libraries will not be happy with either itemtype or patron category - until we have all the dimensions, things will always not work well for someone.
Comment 7 Fiona Borthwick 2020-04-20 09:57:15 UTC
I think moving this into the circ rules will work well. The downside is that there are already many attributes within the circ rules and there is the potential for libraries to maintain many more policies if they have a lot of combinations. In my experience though there shouldn't be too many variations.
Comment 8 Sally 2020-04-20 10:07:12 UTC
+1

Putting hold fees into the circulation rules would add a lot of flexibility.

It would also be useful if ExpireReservesMaxPickUpDelayCharge (the charge for holds not collected) could pick up the hold fee in the circulation rule, rather than being a blanket charge across all patron categories and itemtypes.

There's a separate bug for that here:  https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18195 - but I mention it in case it's something that can be explored at the same time.
Comment 9 Martin Renvoize 2021-04-20 13:21:10 UTC
Looking into this... Moving to the circulation rules adds an additional question..

Whilst I can understand the want to add rules at itemtype and patron category levels.. would there also be a need to do this at a branch level too... and if that is the case.. which branch would govern the looking.. the pickup location, the items home library, the items current holding library?.. it opens a bit of a can of worms ;)
Comment 10 Martin Renvoize 2021-04-20 13:33:41 UTC
Aha, GetReservesControlBranch deals with this for us already.. so it's a non-issue.
Comment 11 Martin Renvoize 2021-04-20 13:52:45 UTC
(In reply to Martin Renvoize from comment #10)
> Aha, GetReservesControlBranch deals with this for us already.. so it's a
> non-issue.

Humm.. actually, it doesn't.

`GetReservesControlBranch` requires an item (for the case where `ReservesControlBranch` is set to 'ItemHomeLibrary'). However, at the time of reserve we don't always have that information yet (Bib level holds).. so for the case where we charge at the point of placing a hold and we allow biblio level holds.. we would explode.

Rethink needed.
Comment 12 Martin Renvoize 2021-04-20 13:59:26 UTC
Created attachment 119909 [details] [review]
Bug 3492: Begginings of moving holds_fee rule to circulation rules
Comment 13 Martin Renvoize 2021-04-20 13:59:48 UTC
This is just a starting point so far.. not complete yet
Comment 14 Katrin Fischer 2023-01-07 22:48:13 UTC
I have updated the bug description per the discussion below.

HoldFeeMode already allows to charge when placing a hold.