In the OPAC, the sort by 'Current library' in the holdings table for a record doesn't work. Sorting of other columns seem to work okay (change one of the item types for an item, collection code, and add different call numbers to test). To replicate: 1. Go to a record in the OPAC that has multiple items in different libraries (126 - Intermediate Perl has four items in three different libraries). 2. In the holdings tab, click the 'Current library' column. 3. Note that the sort order doesn't change.
Confirmed the bug, but not sure what the problem is :(
Created attachment 156797 [details] [review] Bug 35006: OPAC holdings table - Fix sort for library columns This patch updates the holdings table on the OPAC's bibliographic detail page so that home and current library columns can be sorted correctly by library name. There have been changes to the way the template shows these values, but the DataTables "data-sort" attribute on the table cell had not been updated accordingly. To test, apply the patch set the OpacLocationBranchToDisplay system preference to "home and holding libraries." - Make sure home and holding library columns are not hidden in the table settings under Administration -> Table settings -> OPAC -> holdingst. - Locate a bibliographic record in the OPAC which has multiple items from different libraries. - Test that the home and current library columns sort correctly by library name.
Created attachment 156804 [details] [review] Bug 35006: OPAC holdings table - Fix sort for library columns This patch updates the holdings table on the OPAC's bibliographic detail page so that home and current library columns can be sorted correctly by library name. There have been changes to the way the template shows these values, but the DataTables "data-sort" attribute on the table cell had not been updated accordingly. To test, apply the patch set the OpacLocationBranchToDisplay system preference to "home and holding libraries." - Make sure home and holding library columns are not hidden in the table settings under Administration -> Table settings -> OPAC -> holdingst. - Locate a bibliographic record in the OPAC which has multiple items from different libraries. - Test that the home and current library columns sort correctly by library name. Signed-off-by: David Nind <david@davidnind.com>
Thanks Owen!
Created attachment 156873 [details] [review] Bug 35006: OPAC holdings table - Fix sort for library columns This patch updates the holdings table on the OPAC's bibliographic detail page so that home and current library columns can be sorted correctly by library name. There have been changes to the way the template shows these values, but the DataTables "data-sort" attribute on the table cell had not been updated accordingly. To test, apply the patch set the OpacLocationBranchToDisplay system preference to "home and holding libraries." - Make sure home and holding library columns are not hidden in the table settings under Administration -> Table settings -> OPAC -> holdingst. - Locate a bibliographic record in the OPAC which has multiple items from different libraries. - Test that the home and current library columns sort correctly by library name. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x