On the detail page, under the items groups tab, the table headers don't display correctly (especially with Bug 34913 applied). This is because the header row contains <td>s instead of <th>s.
Created attachment 157558 [details] [review] Bug 35124: Incorrect item groups table markup This patch corrects the markup of the item groups table which is found under the "Item groups" tab on the bibliographip detail page in the staff interface. The patch also adds the "NoSort" class to the "actions" column to prevent it from being sortable. To test, apply the patch and make sure the "EnableItemGroups" system preference is enabled. - In the staff interface, locate a record with items and view the detail page. - Under the "Item groups" tab confirm that the table looks correct: The heading labels should be centered bold text. - You should see sorting indicators on the "Display order" and "Description" headings but not on the last one.
Created attachment 157581 [details] [review] Bug 35124: Incorrect item groups table markup This patch corrects the markup of the item groups table which is found under the "Item groups" tab on the bibliographip detail page in the staff interface. The patch also adds the "NoSort" class to the "actions" column to prevent it from being sortable. To test, apply the patch and make sure the "EnableItemGroups" system preference is enabled. - In the staff interface, locate a record with items and view the detail page. - Under the "Item groups" tab confirm that the table looks correct: The heading labels should be centered bold text. - You should see sorting indicators on the "Display order" and "Description" headings but not on the last one. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 157593 [details] [review] Bug 35124: Incorrect item groups table markup This patch corrects the markup of the item groups table which is found under the "Item groups" tab on the bibliographip detail page in the staff interface. The patch also adds the "NoSort" class to the "actions" column to prevent it from being sortable. To test, apply the patch and make sure the "EnableItemGroups" system preference is enabled. - In the staff interface, locate a record with items and view the detail page. - Under the "Item groups" tab confirm that the table looks correct: The heading labels should be centered bold text. - You should see sorting indicators on the "Display order" and "Description" headings but not on the last one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x