See bug 35507. Since KitchenSink contains CREATE TABLE, it commits cruft into db. Lets control that a bit more.
Created attachment 160115 [details] [review] Bug 35548: Test KitchenSink plugin Removed from Plugins.t on bug 35507. Restoring it here on its own. Simplified a bit. NOTE: The CREATE IF NOT EXISTS seems to commit even when the table already exists. Therefore mocking install too. Test plan: Check number of records in plugin_data/methods. Run t/db_dependent/Koha/Plugins/KitchenSink.t Check again number of records in plugin_data/methods. Same? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 160826 [details] [review] Bug 35548: Test KitchenSink plugin Removed from Plugins.t on bug 35507. Restoring it here on its own. Simplified a bit. NOTE: The CREATE IF NOT EXISTS seems to commit even when the table already exists. Therefore mocking install too. Test plan: Check number of records in plugin_data/methods. Run t/db_dependent/Koha/Plugins/KitchenSink.t Check again number of records in plugin_data/methods. Same? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 160990 [details] [review] Bug 35548: Test KitchenSink plugin Removed from Plugins.t on bug 35507. Restoring it here on its own. Simplified a bit. NOTE: The CREATE IF NOT EXISTS seems to commit even when the table already exists. Therefore mocking install too. Test plan: Check number of records in plugin_data/methods. Run t/db_dependent/Koha/Plugins/KitchenSink.t Check again number of records in plugin_data/methods. Same? Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Test is failing on D10 15:36:16 koha_1 | # Failed test 'No tests run for subtest "Fun with KitchenSink, Handler->delete"' 15:36:16 koha_1 | # at t/db_dependent/Koha/Plugins/KitchenSink.t line 72. 15:36:16 koha_1 | Can't locate object method "mock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Koha/Plugins/KitchenSink.t line 56. See commit d130a6c66b6cc6fb3221c0ea7e26f2d0825f4f72 Bug 35962: (bug 35843 follow-up 2) Fix BackgroundJob.t on D10 for a solution to the same failure.
Created attachment 163765 [details] [review] Bug 35548: (follow-up) Fix mock statement for D10 Test plan: Run t/db_dependent/Koha/Plugins/KitchenSink.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Follow-up pushed to master.