Bug 35548 - Move KitchenSink test on its own and control table creation
Summary: Move KitchenSink test on its own and control table creation
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Kyle M Hall
URL:
Keywords: roadmap_24_05
Depends on: 35507 35536
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-12 15:41 UTC by Marcel de Rooy
Modified: 2024-01-12 17:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35548: Test KitchenSink plugin (4.47 KB, patch)
2023-12-20 12:46 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35548: Test KitchenSink plugin (4.50 KB, patch)
2024-01-11 09:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35548: Test KitchenSink plugin (4.55 KB, patch)
2024-01-12 17:05 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-12-12 15:41:40 UTC
See bug 35507.
Since KitchenSink contains CREATE TABLE, it commits cruft into db.
Lets control that a bit more.
Comment 1 Marcel de Rooy 2023-12-20 12:46:28 UTC
Created attachment 160115 [details] [review]
Bug 35548: Test KitchenSink plugin

Removed from Plugins.t on bug 35507.
Restoring it here on its own.
Simplified a bit.

NOTE: The CREATE IF NOT EXISTS seems to commit even when the
table already exists. Therefore mocking install too.

Test plan:
Check number of records in plugin_data/methods.
Run t/db_dependent/Koha/Plugins/KitchenSink.t
Check again number of records in plugin_data/methods. Same?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Martin Renvoize 2024-01-11 09:55:12 UTC
Created attachment 160826 [details] [review]
Bug 35548: Test KitchenSink plugin

Removed from Plugins.t on bug 35507.
Restoring it here on its own.
Simplified a bit.

NOTE: The CREATE IF NOT EXISTS seems to commit even when the
table already exists. Therefore mocking install too.

Test plan:
Check number of records in plugin_data/methods.
Run t/db_dependent/Koha/Plugins/KitchenSink.t
Check again number of records in plugin_data/methods. Same?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Kyle M Hall 2024-01-12 17:05:49 UTC
Created attachment 160990 [details] [review]
Bug 35548: Test KitchenSink plugin

Removed from Plugins.t on bug 35507.
Restoring it here on its own.
Simplified a bit.

NOTE: The CREATE IF NOT EXISTS seems to commit even when the
table already exists. Therefore mocking install too.

Test plan:
Check number of records in plugin_data/methods.
Run t/db_dependent/Koha/Plugins/KitchenSink.t
Check again number of records in plugin_data/methods. Same?

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>