Bug 10950 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950) adds a pronoun text field to the patron record. The display of this field depends on HidePersonalPatronDetailOnCirculation but the description of this syspref only mentions phone number, email address, street address and city. Pronoun should be added to this description.
I think pronouns are very useful for circulation. When user has first name and surname it makes sense to have pronouns. So I propose to move pronouns outside HidePersonalPatronDetailOnCirculation block.
Created attachment 163821 [details] [review] Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed
It works for me : address or phone number are hidden but pronom still displays. Someone else to test and sign off ?
Created attachment 164006 [details] [review] Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed Signed-off-by: Hebah <hebah@bywatersolutions.com>
Works as described.
Trivial change that looks good to me.
Created attachment 164011 [details] [review] Bug 35599: Fix Pronouns and HidePersonalPatronDetailOnCirculation Bug 10950 adds a pronouns text field to the patron record. Currently it is hidden by system preference 'HidePersonalPatronDetailOnCirculation'. This patch moves pronouns outside this system preference influence. Test plan: 1) Add pronouns to a patron 2) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Don't hide" 3) Check you see pronouns in circulation page /cgi-bin/koha/circ/circulation.pl?borrowernumber=X 4) Set system preference 'HidePersonalPatronDetailOnCirculation' to "Hide" 5) Refresh circulation page => Without patch pronouns are hidden => With patch pronouns are displayed Signed-off-by: Hebah <hebah@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Please add a note to the release notes about this change.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12