Bug 35656 - Autorenewal notices can resend content that has already been relayed to the patron
Summary: Autorenewal notices can resend content that has already been relayed to the p...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-27 16:05 UTC by Lucas Gass (lukeg)
Modified: 2024-10-10 08:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Content resending continues when items overdue (493.09 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-10-10 08:10 UTC, Ray Delahunty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-12-27 16:05:04 UTC
To recreate: 

1. Enable AutoRenewalNotices
2. Choose a patron and make sure they have an email address and messaging prefs set to revieve an AUTO_RENEWAL_DGST 
3. Set Circ rules so automatic_reneal is on
4. Check out several items (item 1, item 2, and item 3) to your chosen patron, and make sure they are within range of auto renewing via circ rule "No renewal before"
5. Put item 1, item 2, and item 3 on hold for someone else.
6. Run the autorenewal script.
7. Patron receives message that item 1, item 2, and item 3 will not be renewed because they are on hold for someone else.
8. Checkout item 4, making sure it is within range of auto renewing via circ rule "No renewal before".
9. Run the script, item 4 will successfully auto renew. However the notice always states that item 1, item 2, and item 3 on hold for someone else.


Since the patron has already receievd a notice that item 1, item 2, and item 3 are on hold for someone else they do not want to be told again. The 2nd notice ( step 6 ) should only notifiy the patron that item 4 has been renewed. 

Currently, if 1 item changes in status we will resend info. about ALL renewals, even if patron has been notified.

The autorenewal script should only send information on items that have changed in status.
Comment 1 Juliet Heltibridle 2024-07-18 17:36:09 UTC
Fixing this would be a great improvement. It can be confusing to keep receiving the old renewal information every time new information is emailed, and sometimes it is easy to miss what information is new.
Comment 2 Ray Delahunty 2024-10-10 08:10:08 UTC
Created attachment 172580 [details]
Content resending continues when items overdue

Items that have failed to renew continue to appear on the renewals digest when they are also appearing on the ODUE emails.