Unless there is some purpose to these hidden labels, we could probably do away with these labels. Perhaps just assign classes to the data they are labeling instead?
Created attachment 167979 [details] [review] Bug 35808: Remove obsolete .tdlabel markup This patch removes span.tdlabel from several templates. The markup is obsolete now that we use the DataTables responsive feature. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Log in to the OPAC as a user with checkouts, suggestions, and tags. - Check these pages to confirm that the tables on each one have the correct responsive behavior at varying browser widths: - OPAC home -> Most popular - Your account - Your account -> Checkout history - Your account -> Suggestions - Your account -> Tags * The recalls history page is fixed in Bug 37158 Sponsored-by: Athens County Public Libraries
Created attachment 168000 [details] [review] Bug 35808: Remove obsolete .tdlabel markup This patch removes span.tdlabel from several templates. The markup is obsolete now that we use the DataTables responsive feature. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Log in to the OPAC as a user with checkouts, suggestions, and tags. - Check these pages to confirm that the tables on each one have the correct responsive behavior at varying browser widths: - OPAC home -> Most popular - Your account - Your account -> Checkout history - Your account -> Suggestions - Your account -> Tags * The recalls history page is fixed in Bug 37158 Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
TIL we have a preffed-off Most popular feature, for when you are worried the latest James Patterson books don't have enough holds.
A conflict in the scss - can you please rebase? Can we also make the bug description a bit more user friendly (avoiding the file name :) )
Created attachment 170994 [details] [review] Bug 35808: Remove obsolete responsive table markup from several pages in the OPAC This patch removes span.tdlabel from several templates. The markup is obsolete now that we use the DataTables responsive feature. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Log in to the OPAC as a user with checkouts, suggestions, and tags. - Check these pages to confirm that the tables on each one have the correct responsive behavior at varying browser widths: - OPAC home -> Most popular - Your account - Your account -> Checkout history - Your account -> Suggestions - Your account -> Tags * The recalls history page is fixed in Bug 37158 Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Thanks Owen! QA by RM. No more occurences of tdlabel found.
Pushed for 25.05! Well done everyone, thank you!