Bug 35808 - Remove obsolete responsive table markup from several pages in the OPAC
Summary: Remove obsolete responsive table markup from several pages in the OPAC
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 37907
  Show dependency treegraph
 
Reported: 2024-01-14 00:19 UTC by Christopher Brannon
Modified: 2025-01-03 23:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement removes obsolete responsive table markup (span.tdlabel) from several OPAC pages, as the tables now use the DataTables responsive features.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 35808: Remove obsolete .tdlabel markup (18.03 KB, patch)
2024-06-21 17:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35808: Remove obsolete .tdlabel markup (18.09 KB, patch)
2024-06-22 02:03 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35808: Remove obsolete responsive table markup from several pages in the OPAC (18.20 KB, patch)
2024-09-03 17:09 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2024-01-14 00:19:52 UTC
Unless there is some purpose to these hidden labels, we could probably do away with these labels.  Perhaps just assign classes to the data they are labeling instead?
Comment 1 Owen Leonard 2024-06-21 17:34:34 UTC
Created attachment 167979 [details] [review]
Bug 35808: Remove obsolete .tdlabel markup

This patch removes span.tdlabel from several templates. The markup is
obsolete now that we use the DataTables responsive feature.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Log in to the OPAC as a user with checkouts, suggestions, and tags.
- Check these pages to confirm that the tables on each one have the
  correct responsive behavior at varying browser widths:
  - OPAC home -> Most popular
  - Your account
  - Your account -> Checkout history
  - Your account -> Suggestions
  - Your account -> Tags
* The recalls history page is fixed in Bug 37158

Sponsored-by: Athens County Public Libraries
Comment 2 Phil Ringnalda 2024-06-22 02:03:56 UTC
Created attachment 168000 [details] [review]
Bug 35808: Remove obsolete .tdlabel markup

This patch removes span.tdlabel from several templates. The markup is
obsolete now that we use the DataTables responsive feature.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Log in to the OPAC as a user with checkouts, suggestions, and tags.
- Check these pages to confirm that the tables on each one have the
  correct responsive behavior at varying browser widths:
  - OPAC home -> Most popular
  - Your account
  - Your account -> Checkout history
  - Your account -> Suggestions
  - Your account -> Tags
* The recalls history page is fixed in Bug 37158

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Phil Ringnalda 2024-06-22 02:05:03 UTC
TIL we have a preffed-off Most popular feature, for when you are worried the latest James Patterson books don't have enough holds.
Comment 4 Katrin Fischer 2024-09-02 09:44:39 UTC
A conflict in the scss - can you please rebase?
Can we also make the bug description a bit more user friendly (avoiding the file name :) )
Comment 5 Owen Leonard 2024-09-03 17:09:26 UTC
Created attachment 170994 [details] [review]
Bug 35808: Remove obsolete responsive table markup from several pages in the OPAC

This patch removes span.tdlabel from several templates. The markup is
obsolete now that we use the DataTables responsive feature.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

- Log in to the OPAC as a user with checkouts, suggestions, and tags.
- Check these pages to confirm that the tables on each one have the
  correct responsive behavior at varying browser widths:
  - OPAC home -> Most popular
  - Your account
  - Your account -> Checkout history
  - Your account -> Suggestions
  - Your account -> Tags
* The recalls history page is fixed in Bug 37158

Sponsored-by: Athens County Public Libraries
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 6 Katrin Fischer 2024-12-27 16:26:48 UTC
Thanks Owen! QA by RM.

No more occurences of tdlabel found.
Comment 7 Katrin Fischer 2024-12-27 16:36:05 UTC
Pushed for 25.05!

Well done everyone, thank you!