From bug 35329 comment 59 > Next comment.. could we perhaps put the results next to rather than under > the filters form in the modal? > > It feels odd to have so much whitespace in the modal and have the actual > useful content almost hidden off screen.. widescreen aspect ratios are > pretty common these days?
*** Bug 35846 has been marked as a duplicate of this bug. ***
Created attachment 162858 [details] [review] Bug 35862: Display modal search results to the right of form above 1200px To test: 1. Apply patch 2. Rebuild CSS ( yarn build ) 3. Look at some of the places where there is a modal patron search. -suggestion/suggestion.pl: Set to patron -members/memberentry.pl: Add guarantor 4. Make sure the modal looks good before and after you have searched for a patron. 5. Play with many different screen sizes, ensuring everything looks good and makes sense.
Created attachment 162862 [details] [review] Bug 35862: Display modal search results to the right of form above 1200px To test: 1. Apply patch 2. Rebuild CSS ( yarn build ) 3. Look at some of the places where there is a modal patron search. -suggestion/suggestion.pl: Set to patron -members/memberentry.pl: Add guarantor 4. Make sure the modal looks good before and after you have searched for a patron. 5. Play with many different screen sizes, ensuring everything looks good and makes sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This is a huge improvement, thanks Lucas. Signing off.
Do we want the 100% width for inputs/select on small screens? https://snipboard.io/iwo0lI.jpg
(In reply to Jonathan Druart from comment #5) > Do we want the 100% width for inputs/select on small screens? > https://snipboard.io/iwo0lI.jpg It's a good question. I personally think so. But I am happy to change it if we don't think that will be well received.
I like the 100% myself.
Created attachment 162959 [details] [review] Bug 35862: Display modal search results to the right of form above 1200px To test: 1. Apply patch 2. Rebuild CSS ( yarn build ) 3. Look at some of the places where there is a modal patron search. -suggestion/suggestion.pl: Set to patron -members/memberentry.pl: Add guarantor 4. Make sure the modal looks good before and after you have searched for a patron. 5. Play with many different screen sizes, ensuring everything looks good and makes sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.05! Well done everyone, thank you!
This one appears to break the patron_search selenium tests.. I'm working on the resolution now.
False alarm.. it's actually bug 35362 that breaks the test (and the functionality too)
Created attachment 166687 [details] [review] Bug 35862: Remove dup aside node The aside element is now a parent of the form block, in patron-search.inc (BLOCK patron_search_filters). On members/members-home.pl there were 2 nested aside
Created attachment 166688 [details] [review] Bug 35862: Fix patron_search_form selection We were no longer getting a match here and so ended up with 2 forms on the budget page (where we have two modals for patron: owner and users). Caught be selenium tests patrons_search.t : Error while executing command: element not interactable: Element <a class="patron_name patron_preview" href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=511"> could not be scrolled into view It fixes the following UI issues: When you open a modal, start a search, close the modal open the other modal search: the results from the other modal were shown
Picked the 2 follow-up patches for inclusion in main.
Depends on Bug 35329 not in 23.11.x