Bug 35865 - Missing hint about permissions when adding managers to a basket
Summary: Missing hint about permissions when adding managers to a basket
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 35329
  Show dependency treegraph
 
Reported: 2024-01-22 21:05 UTC by Jonathan Druart
Modified: 2024-02-09 20:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09


Attachments
Bug 35865: Add missing hint about permissions when adding managers to a basket (1.77 KB, patch)
2024-01-22 21:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35865: Add missing hint about permissions when adding managers to a basket (1.92 KB, patch)
2024-01-23 08:58 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 35865: Add missing hint about permissions when adding managers to a basket (1.99 KB, patch)
2024-01-23 11:47 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-22 21:05:19 UTC
When searching for managers for an acquisition basket, the list of patrons is limited to patrons with the baskets_managers permission. For other patron searches there is a hint about the restriction but it does not appears here.
Comment 1 Jonathan Druart 2024-01-22 21:08:55 UTC
Created attachment 161261 [details] [review]
Bug 35865: Add missing hint about permissions when adding managers to a basket

When searching for managers for an acquisition basket, the list of patrons is
limited to patrons with the baskets_managers permission. For other patron
searches there is a hint about the restriction but it does not appears here.

Test plan;
Edit a basket, click "Add user" to select a manager.
Notice the hint about the permission.
Comment 2 Loïc 2024-01-23 08:57:45 UTC
It works
Comment 3 Biblibre Sandboxes 2024-01-23 08:58:33 UTC
Created attachment 161266 [details] [review]
Bug 35865: Add missing hint about permissions when adding managers to a basket

When searching for managers for an acquisition basket, the list of patrons is
limited to patrons with the baskets_managers permission. For other patron
searches there is a hint about the restriction but it does not appears here.

Test plan;
Edit a basket, click "Add user" to select a manager.
Notice the hint about the permission.

Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr>
Comment 4 Martin Renvoize 2024-01-23 11:47:44 UTC
Created attachment 161296 [details] [review]
Bug 35865: Add missing hint about permissions when adding managers to a basket

When searching for managers for an acquisition basket, the list of patrons is
limited to patrons with the baskets_managers permission. For other patron
searches there is a hint about the restriction but it does not appears here.

Test plan;
Edit a basket, click "Add user" to select a manager.
Notice the hint about the permission.

Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2024-01-23 11:48:05 UTC
Thanks for the quick fix Jonathan.. Passing QA :)
Comment 6 Katrin Fischer 2024-01-26 14:18:29 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-31 13:52:01 UTC
Pushed to 23.11.x for 23.11.03
Comment 8 Lucas Gass 2024-02-09 20:27:49 UTC
Backported to 23.05.x for upcoming 23.05.09