Bug 34169 broke a fall back to the GetMarcPrice routine when ordering from a file. Previously if there was no order, the field was blank and evaluated as 'false' and we used the price from the MARC record. Now the field is '0.00' if no price is mapped in MarcFieldsToOrder. perl -e 'warn "True" if "0.00"'; IN addorderiso2907.pl: my $c_price = $input->param( 'price_' . $import_record->import_record_id ) || GetMarcPrice( $marcrecord, C4::Context->preference('marcflavour') ); We could simply add 0 to tthe value to make it a number: perl -e 'warn "True" if "0.00"+ 0'; However, this would mean leaving the field at 0.00 when you didn't pay for something would change it to the GetMarcPrice. I think the solution may be to populate the field using the GetMarcPrice on the initial load. You can workaround this by adding the fallback to the MarcFieldsToOrder system preference: price: 947$c|020$c Which may be a viable solution for updating/editing the default values/documentatoin for that preference
Created attachment 161466 [details] [review] Bug 35892: Populate order price using GetMarcPrice if no price specified Previously this happened after the fact, automagically, if no price was included in the order record. We should rather load the Marc price into the order form if we don't have a price form the '...ToOrder' system preferences To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Note that item prices are populated as '6.50' from 949$g Cancel Update MarcFieldsToOrder and map price to "020$c" Add to basket from the staged file Note the price is not populated, because 020$c contains a dollar sign Cancel Apply patch, restart all Add to basket from the staged file Note the price is now correctly populated from fallback to GetMarcPrice Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own doesn't work - this could be done to fields in MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement. This bug simply restores the previous behavious, but does it on the front end and is more obvious to the user
Created attachment 161467 [details] Test order file
Created attachment 161468 [details] [review] Bug 35892: Populate order price using GetMarcPrice if no price specified Previously this happened after the fact, automagically, if no price was included in the order record. We should rather load the Marc price into the order form if we don't have a price form the '...ToOrder' system preferences To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Note that item prices are populated as '6.50' from 949$g Cancel Update MarcFieldsToOrder and map price to "020$c" Add to basket from the staged file Note the price is not populated, because 020$c contains a dollar sign Cancel Apply patch, restart all Add to basket from the staged file Note the price is now correctly populated from fallback to GetMarcPrice Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own doesn't work - this could be done to fields in MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement. This bug simply restores the previous behavious, but does it on the front end and is more obvious to the user Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Depends on a NSO ? Blocked
Removing dependencies on 35912 and 35913 - they are useful for testing, so that all order prices populate correctly, however, this is present from 23.05 and forward and others are not
Created attachment 162643 [details] [review] Bug 35892: Populate order price using GetMarcPrice if no price specified Previously this happened after the fact, automagically, if no price was included in the order record. We should rather load the Marc price into the order form if we don't have a price form the '...ToOrder' system preferences To test: Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l Stage the attached bib-303.marcxml file Add to basket from the staged file Note that item prices are populated as '6.50' from 949$g Cancel Update MarcFieldsToOrder and map price to "020$c" Add to basket from the staged file Note the price is not populated, because 020$c contains a dollar sign Cancel Apply patch, restart all Add to basket from the staged file Note the price is now correctly populated from fallback to GetMarcPrice Note: GetMarcPrice does some automatic munging, that's why 020$c on it's own doesn't work - this could be done to fields in MarcFieldsToOrder/MarcItemFieldsToOrder but this would be an enhancement. This bug simply restores the previous behavious, but does it on the front end and is more obvious to the user Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Backported to 23.05.x for upcoming 23.05.10