Bug 35911 - Archived suggestions show in patron's account
Summary: Archived suggestions show in patron's account
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Shi Yao Wang
QA Contact: Testopia
URL:
Keywords:
Depends on: 23991
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-25 18:24 UTC by Caroline Cyr La Rose
Modified: 2024-03-19 21:03 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes an unintended change introduced in Koha 22.11. Archived suggestions are now no longer shown on the patron's account page in the staff interface.
Version(s) released in:
24.05.00,23.11.04,23.05.10


Attachments
Bug 35911: Make archived suggestions not show in patron's account (1.57 KB, patch)
2024-02-23 20:07 UTC, Shi Yao Wang
Details | Diff | Splinter Review
Bug 35911: Make archived suggestions not show in patron's account (1.62 KB, patch)
2024-02-26 07:17 UTC, David Nind
Details | Diff | Splinter Review
Bug 35911: Make archived suggestions not show in patron's account (1.70 KB, patch)
2024-02-29 10:32 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-01-25 18:24:05 UTC
I don't know if this was meant as an enhancement or it's a regression, but since 22.11, archived suggestions show in the patron's "Suggestions" tab in the staff interface. 

It has been reported by many of our clients as a bug, so if it was intended, maybe we should add a syspref to hide them?

To recreate:
1. Go to a patron's account in the staff interface
2. Go to the Suggestions tab
3. Click New purchase suggestion and create a suggestion
4. In another browser tab, go to Acquisitions > Suggestions
5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected)
   --> Suggestion disappears from the suggestions management page (OK)
6. Go back to the tab with the patron's account and refresh
   --> Suggestion is still visible

Prior to 22.11, archived suggestions were not visible in the patron's account.
Comment 1 Caroline Cyr La Rose 2024-01-25 18:25:32 UTC
If it was intended to show them, could we at least make them greyed out?
Comment 2 Caroline Cyr La Rose 2024-01-25 18:30:09 UTC
And if it was intended to show them, could we add a filter? I would hide the archived suggestions by default and have a filter "Show archived suggestions", but that might change the current (unwanted in my case) behaviour.
Comment 3 Katrin Fischer 2024-01-25 20:41:50 UTC
Hm, as patrons can't archive suggestions themselves it would make sense to me that they can see all suggestions they made and the status of them. I assumed archiving was for staff to have a means to reduce the number of suggestions in queues.
Comment 4 Katrin Fischer 2024-01-25 20:42:30 UTC
Or do you mean only in staff? Maybe a checkbox "show archived" would be nice then in case they come to ask about already archived ones.
Comment 5 Caroline Cyr La Rose 2024-01-25 20:45:31 UTC
I meant in the staff interface, in the patron's account in the Suggestions tab.

There is a discussion about seeing the archived suggestions in the OPAC in another bug (bug 27635).
Comment 6 Shi Yao Wang 2024-02-23 20:07:48 UTC
Created attachment 162403 [details] [review]
Bug 35911: Make archived suggestions not show in patron's account

Remove archived suggestions in patron's account page

Test plan:
1. Go to a patron's account in the staff interface
2. Go to the Suggestions tab
3. Click New purchase suggestion and create a suggestion
4. In another browser tab, go to Acquisitions > Suggestions
5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected)
   --> Suggestion disappears from the suggestions management page (OK)
6. Go back to the tab with the patron's account and refresh
   --> Suggestion is still visible
7. Apply the patch
8. Redo step 6 and notice the suggestion is not visible anymore
9. Redo step 4 and 5 but this time, unarchiving the suggestion
10. Redo step 6 and notice the suggestion is back
Comment 7 David Nind 2024-02-26 07:17:05 UTC
Created attachment 162419 [details] [review]
Bug 35911: Make archived suggestions not show in patron's account

Remove archived suggestions in patron's account page

Test plan:
1. Go to a patron's account in the staff interface
2. Go to the Suggestions tab
3. Click New purchase suggestion and create a suggestion
4. In another browser tab, go to Acquisitions > Suggestions
5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected)
   --> Suggestion disappears from the suggestions management page (OK)
6. Go back to the tab with the patron's account and refresh
   --> Suggestion is still visible
7. Apply the patch
8. Redo step 6 and notice the suggestion is not visible anymore
9. Redo step 4 and 5 but this time, unarchiving the suggestion
10. Redo step 6 and notice the suggestion is back

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 David Nind 2024-02-26 07:21:52 UTC
I have signed off, as the test plan does what it says.

For steps 9 and 10 I used the filter on the Acquisitions > Suggestion management page to include archived suggestions and then unarchived a suggestion.

However, I think I would like to see a way to filter or show archived suggestions on the patrons suggestion page:
- The message when they have no current suggestions is "This patron has not submitted any purchase suggestions", even though they may have archived suggestions
Comment 9 Jonathan Druart 2024-02-29 10:32:27 UTC
Created attachment 162583 [details] [review]
Bug 35911: Make archived suggestions not show in patron's account

Remove archived suggestions in patron's account page

Test plan:
1. Go to a patron's account in the staff interface
2. Go to the Suggestions tab
3. Click New purchase suggestion and create a suggestion
4. In another browser tab, go to Acquisitions > Suggestions
5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected)
   --> Suggestion disappears from the suggestions management page (OK)
6. Go back to the tab with the patron's account and refresh
   --> Suggestion is still visible
7. Apply the patch
8. Redo step 6 and notice the suggestion is not visible anymore
9. Redo step 4 and 5 but this time, unarchiving the suggestion
10. Redo step 6 and notice the suggestion is back

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2024-02-29 10:33:00 UTC
Definitely an unintended change in behaviour introduced by bug 23991.
Comment 11 Katrin Fischer 2024-03-08 17:59:28 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 12 Fridolin Somers 2024-03-11 14:16:31 UTC
Pushed to 23.11.x for 23.11.04
Comment 13 Lucas Gass 2024-03-19 21:03:30 UTC
Backported to 23.05.x for upcoming 23.05.10