I don't know if this was meant as an enhancement or it's a regression, but since 22.11, archived suggestions show in the patron's "Suggestions" tab in the staff interface. It has been reported by many of our clients as a bug, so if it was intended, maybe we should add a syspref to hide them? To recreate: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible Prior to 22.11, archived suggestions were not visible in the patron's account.
If it was intended to show them, could we at least make them greyed out?
And if it was intended to show them, could we add a filter? I would hide the archived suggestions by default and have a filter "Show archived suggestions", but that might change the current (unwanted in my case) behaviour.
Hm, as patrons can't archive suggestions themselves it would make sense to me that they can see all suggestions they made and the status of them. I assumed archiving was for staff to have a means to reduce the number of suggestions in queues.
Or do you mean only in staff? Maybe a checkbox "show archived" would be nice then in case they come to ask about already archived ones.
I meant in the staff interface, in the patron's account in the Suggestions tab. There is a discussion about seeing the archived suggestions in the OPAC in another bug (bug 27635).
Created attachment 162403 [details] [review] Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back
Created attachment 162419 [details] [review] Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back Signed-off-by: David Nind <david@davidnind.com>
I have signed off, as the test plan does what it says. For steps 9 and 10 I used the filter on the Acquisitions > Suggestion management page to include archived suggestions and then unarchived a suggestion. However, I think I would like to see a way to filter or show archived suggestions on the patrons suggestion page: - The message when they have no current suggestions is "This patron has not submitted any purchase suggestions", even though they may have archived suggestions
Created attachment 162583 [details] [review] Bug 35911: Make archived suggestions not show in patron's account Remove archived suggestions in patron's account page Test plan: 1. Go to a patron's account in the staff interface 2. Go to the Suggestions tab 3. Click New purchase suggestion and create a suggestion 4. In another browser tab, go to Acquisitions > Suggestions 5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) --> Suggestion disappears from the suggestions management page (OK) 6. Go back to the tab with the patron's account and refresh --> Suggestion is still visible 7. Apply the patch 8. Redo step 6 and notice the suggestion is not visible anymore 9. Redo step 4 and 5 but this time, unarchiving the suggestion 10. Redo step 6 and notice the suggestion is back Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Definitely an unintended change in behaviour introduced by bug 23991.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Backported to 23.05.x for upcoming 23.05.10