Bug 35953 - Add delete_any_record cataloguing subpermission
Summary: Add delete_any_record cataloguing subpermission
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: wainuiwitikapark
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-31 02:27 UTC by wainuiwitikapark
Modified: 2024-03-29 20:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35953: Add delete_any_record cataloguing subpermission (5.43 KB, patch)
2024-02-02 01:52 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 35953: Add delete_any_record cataloguing subpermission (5.25 KB, patch)
2024-02-07 22:38 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Bug 35953: Add delete_any_record cataloguing subpermission (5.25 KB, patch)
2024-02-14 01:04 UTC, wainuiwitikapark
Details | Diff | Splinter Review
Works as described: (5.31 KB, patch)
2024-02-23 19:29 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description wainuiwitikapark 2024-01-31 02:27:55 UTC

    
Comment 1 wainuiwitikapark 2024-02-02 01:52:25 UTC
Created attachment 161720 [details] [review]
Bug 35953: Add delete_any_record cataloguing subpermission

To test:
- apply patch
- create a new test user
- give the test user "catalogue" permissions so that they can enter the staff interface
- also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission
- login to the staff interface as the test user
- do a catalogue search
- click on a result and go to their biblio details page
- notice there is an "Edit" button dropdown
- click on the "Edit" button dropdown and notice there are only 2 results
- change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission
- do another catalogue search and click on the result
- click on the "Edit" button dropdown and notice there are 2 more options: "Edit record" and "Delete record"

Sponsored-by: Education Services Australia SCIS
Comment 2 wainuiwitikapark 2024-02-07 22:38:03 UTC
Created attachment 161859 [details] [review]
Bug 35953: Add delete_any_record cataloguing subpermission

To test:
- apply patch
- create a new test user
- give the test user "catalogue" permissions so that they can enter the staff interface
- also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission
- login to the staff interface as the test user
- do a catalogue search
- click on a result and go to their biblio details page
- notice there is an "Edit" button dropdown
- click on the "Edit" button dropdown and notice there is no option to "Delete record"
- change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission
- do another catalogue search and click on the result
- click on the "Edit" button dropdown and notice there is now an option to "Delete record"

Sponsored-by: Education Services Australia SCIS
Comment 3 wainuiwitikapark 2024-02-14 01:04:27 UTC
Created attachment 162129 [details] [review]
Bug 35953: Add delete_any_record cataloguing subpermission

To test:
- apply patch
- create a new test user
- give the test user "catalogue" permissions so that they can enter the staff interface
- also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission
- login to the staff interface as the test user
- do a catalogue search
- click on a result and go to their biblio details page
- notice there is an "Edit" button dropdown
- click on the "Edit" button dropdown and notice there is no option to "Delete record"
- change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission
- do another catalogue search and click on the result
- click on the "Edit" button dropdown and notice there is now an option to "Delete record"

Sponsored-by: Education Services Australia SCIS
Comment 4 Laura Escamilla 2024-02-23 19:29:32 UTC
Created attachment 162402 [details] [review]
Works as described:

Bug 35953: Add delete_any_record cataloguing subpermission

To test:
- apply patch
- create a new test user
- give the test user "catalogue" permissions so that they can enter the staff interface
- also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission
- login to the staff interface as the test user
- do a catalogue search
- click on a result and go to their biblio details page
- notice there is an "Edit" button dropdown
- click on the "Edit" button dropdown and notice there is no option to "Delete record"
- change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission
- do another catalogue search and click on the result
- click on the "Edit" button dropdown and notice there is now an option to "Delete record"

Sponsored-by: Education Services Australia SCIS
Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 5 Laura Escamilla 2024-02-23 19:32:09 UTC
Agh sorry! I added my message in the incorrect spot during my sign off, but it works as described!
Comment 6 Nick Clemens (kidclamp) 2024-03-29 20:23:06 UTC
Can we get some explanation here on what the purpose is?

If I understand, this is to remove 'deletion' from 'edit_catalogue' and make it a new standalone permission?

If correct we also need to grant the permission existing users with 'editcatalogue' in the database update

I find 'delete_any_record' confusing - edit_any_item is because there are items that can be restricted - are there records that could be restricted and not possible to delete? This plan/patch does not cover authorities, which would be implied by 'any' record.

I do see that 'acquisition->order_manage' seems to grant the ability to delete order related biblios
And the tools permissions for batch deletion allow you to delete items/bibs without cataloging permissions
Have you verified there are not other places from which a biblio can be deleted?