Created attachment 161720 [details] [review] Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there are only 2 results - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there are 2 more options: "Edit record" and "Delete record" Sponsored-by: Education Services Australia SCIS
Created attachment 161859 [details] [review] Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS
Created attachment 162129 [details] [review] Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS
Created attachment 162402 [details] [review] Works as described: Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Agh sorry! I added my message in the incorrect spot during my sign off, but it works as described!
Can we get some explanation here on what the purpose is? If I understand, this is to remove 'deletion' from 'edit_catalogue' and make it a new standalone permission? If correct we also need to grant the permission existing users with 'editcatalogue' in the database update I find 'delete_any_record' confusing - edit_any_item is because there are items that can be restricted - are there records that could be restricted and not possible to delete? This plan/patch does not cover authorities, which would be implied by 'any' record. I do see that 'acquisition->order_manage' seems to grant the ability to delete order related biblios And the tools permissions for batch deletion allow you to delete items/bibs without cataloging permissions Have you verified there are not other places from which a biblio can be deleted?
Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848 removed the ability to delete records from batch item deletion if the user does not have edit_catalogue permission. This is a problem for us because our users without edit_catalogue have used batch item deletion to delete bibliographic records. We do not want to give everyone the permission to edit catalogue because it is a job that takes lot of comptence and should not be done by those who do not know the rules. :) So with that change, it seems that we need a new permission that allows user to delete bibliographic records and not edit them. Permission named delete_catalogue or delete_biblio_records would sound consistent to me.
I'm assigning this to myself with permission from Wainui.
Created attachment 190281 [details] [review] Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 190282 [details] [review] Bug 35953: Rename delete_any_record as delete_bibliographic_records Rename new permission for deleting bibliographic records as delete_any_record. Also rename atomicupdate file and update it to follow current skeleton.pl file example. To test: 1. Apply this patch. 2. Run updatedatabase.pl. => Confirm this new permission was added to Koha. 3. Follow test plan from previous patch. => Confirm everything works as described. Sponsored by: Koha-Suomi Oy
Created attachment 190283 [details] [review] Bug 35953: Add new permission delete_bibliographic_records for patrons with edit_catalogue permission This patch adds new permission delete_bibliographic_records for all patrons who have subpermission edit_catalogue. Patrons with full editcatalogue permissions get permission autmatically. To test: 1. Find patron with subpermission edit_catalogue (or add it for any patron). 2. Apply this patch. 3. Run updatedatabase.pl. => Confirm patron now has also subpermission delete_bibliographic_records. Sponsored-by: Koha-Suomi Oy
Made changes Nick suggested in comment 6. >I do see that 'acquisition->order_manage' seems to grant the ability to delete order related biblios And the tools permissions for batch deletion allow you to delete items/bibs without cataloging permissions Have you verified there are not other places from which a biblio can be deleted? As Anneli mentioned in her comment, batch deletion no longer allows patrons to delete records without edit_catalogue permission. Also I don't quite understand what you mean with that last question. Even if there are other ways to delete biblio records they are most likely (as far as I can tell) tied to permissions to use different modules (like acquisition->order_manage which you mention) and therefor giving them to any patron isn't likely the best idea.
Created attachment 191245 [details] [review] Bug 35953: Do not show Catalogue modal if patron only has permission to delete bibliographic records If patron has only delete_bibliographic_records permission the link to Catalogue modal is still displayed although patron has no permissions to use functions or tools to edit bibliographic record or items. This patch hides the modal link if patron has only delete_bibliographic_records permission. To test: 1. Add delete_bibliographic_records to patron, but to not add any other permissions for them from editcatalogue permissions. 2. Navigate to the main page. => Note that link to the Catalogue modal is displayed. 3. Apply this patch and refresh the main page. => Note that link to the Catalogue modal is no longer displayed. Sponsored-by: Koha-Suomi Oy
Created attachment 191246 [details] [review] Bug 35953: Allow patron with delete_bibliographic_records permission to delete records with Batch item deletion tool Bug 39848 blocked patrons without edit_catalogue permission from deleting bibliographic records with Batch item deletion tool. This can be problematic for those libraries who want to allow their staff to delete records without giving them permission to edit records. This patch allows patrons with delete_bibliographic_records to delete bibliographic record with Batch item deletion tool. To test: 1. Add permission delete_bibliographic_records and items_batchdel for patron. 2. Navigate to Batch item deletion tool, provide barcodes for items to delete and press "Continue". => When lisst of items to delete is loaded note that option to delete records if no items remain is not displayed. 3. Apply this patch and refresh the page. => Note that option to delete the record is now displayed. Sponsored-by: Koha-Suomi Oy