Bug 35994 - New acquisition status method to see if biblio record is still in acquisition
Summary: New acquisition status method to see if biblio record is still in acquisition
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 36018 36068
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-05 14:09 UTC by Marcel de Rooy
Modified: 2024-04-19 18:19 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 35994: Add $biblio->acq_status (4.10 KB, patch)
2024-02-22 14:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35994: Show acq_status on catalogue/detail (2.31 KB, patch)
2024-02-22 14:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35994: Add $biblio->acq_status (4.10 KB, patch)
2024-04-19 07:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35994: Show acq_status on catalogue/detail (2.29 KB, patch)
2024-04-19 07:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35994: Add $biblio->acq_status (4.13 KB, patch)
2024-04-19 18:18 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 35994: Show acq_status on catalogue/detail (2.32 KB, patch)
2024-04-19 18:18 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2024-02-05 14:09:57 UTC
See also bug 35993. Checking for 005 would not be a good way to approach this question.
Comment 1 Marcel de Rooy 2024-02-05 14:11:43 UTC
Note that acquisition of older books may take a long time. In the meantime we may have changed from creating items at ordering, receiving or cataloging. So we cannot just trust checking items.notforloan.
Comment 2 Marcel de Rooy 2024-02-06 14:47:05 UTC
Bug 24430 added biblio->active_orders but they include the lines which are completely received. These are actually 'not-cancelled' orders.
Comment 3 Marcel de Rooy 2024-02-21 13:29:36 UTC
(In reply to Marcel de Rooy from comment #2)
> Bug 24430 added biblio->active_orders but they include the lines which are
> completely received. These are actually 'not-cancelled' orders.

No this is about current orders. And has been addressed now on 36018.
Comment 4 Marcel de Rooy 2024-02-22 14:31:06 UTC
Created attachment 162334 [details] [review]
Bug 35994: Add $biblio->acq_status

This allows you to see quickly if a biblio has linked orders or not.
And if they are all cancelled, or some still in processing, or some
are complete (and the rest cancelled).

Test plan:
Run t/db_dependent/Koha/Biblio.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2024-02-22 14:31:08 UTC
Created attachment 162335 [details] [review]
Bug 35994: Show acq_status on catalogue/detail

Test plan:
Based on the described criteria, check a few biblio records.
Look at Acquisitions tab on the intranet detail page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2024-04-17 13:44:50 UTC
Issue seems to be resolved on 36018. So back to NSO here. Please try again!
Comment 7 Emily Lamancusa 2024-04-17 17:11:46 UTC
This is a nice addition! I can confirm the "unlinked" and "cancelled" statuses work as intended, as well as the "processing" status when nothing has been received yet. I ran into bug 36628 when trying to set up the cases for "acquired", and the "processing" status when some but not all items have been received, though. :(
Comment 8 Emily Lamancusa 2024-04-18 17:05:52 UTC
Ohhh, the error is coming from the dependency, not master - see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018#c24
Comment 9 Marcel de Rooy 2024-04-19 07:40:27 UTC
Created attachment 165154 [details] [review]
Bug 35994: Add $biblio->acq_status

This allows you to see quickly if a biblio has linked orders or not.
And if they are all cancelled, or some still in processing, or some
are complete (and the rest cancelled).

Test plan:
Run t/db_dependent/Koha/Biblio.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2024-04-19 07:40:29 UTC
Created attachment 165155 [details] [review]
Bug 35994: Show acq_status on catalogue/detail

Test plan:
Based on the described criteria, check a few biblio records.
Look at Acquisitions tab on the intranet detail page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 11 Marcel de Rooy 2024-04-19 07:42:44 UTC
(In reply to Emily Lamancusa from comment #8)
> Ohhh, the error is coming from the dependency, not master - see
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36018#c24

Fixed
Comment 12 Emily Lamancusa 2024-04-19 18:18:50 UTC
Created attachment 165224 [details] [review]
Bug 35994: Add $biblio->acq_status

This allows you to see quickly if a biblio has linked orders or not.
And if they are all cancelled, or some still in processing, or some
are complete (and the rest cancelled).

Test plan:
Run t/db_dependent/Koha/Biblio.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 13 Emily Lamancusa 2024-04-19 18:18:53 UTC
Created attachment 165225 [details] [review]
Bug 35994: Show acq_status on catalogue/detail

Test plan:
Based on the described criteria, check a few biblio records.
Look at Acquisitions tab on the intranet detail page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>