Bug 36069 - (bug 29990 follow-up) authority heading use in search results should work with ES as well
Summary: (bug 29990 follow-up) authority heading use in search results should work wit...
Status: RESOLVED DUPLICATE of bug 33348
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Janusz Kaczmarek
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-12 11:42 UTC by Janusz Kaczmarek
Modified: 2024-02-13 15:49 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 36069: (bug 29990 follow-up) authority heading use in search results should work with ES as well (2.20 KB, patch)
2024-02-12 16:37 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 36069: (bug 29990 follow-up) authority heading use in search results should work with ES as well (2.25 KB, patch)
2024-02-13 10:14 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-02-12 11:42:53 UTC
It seems that the enhancement introduced with bug 29990 (syspref: ShowHeadingUse) work only with zebra (generation of main/subject/series use info is made only in C4::AuthoritiesMarc == a zebra incarnation of search_auth_compat) and has no effect on ES search results.

Wouldn't it be great if it worked in ES as well?
Comment 1 Janusz Kaczmarek 2024-02-12 16:37:47 UTC
Created attachment 162062 [details] [review]
Bug 36069: (bug 29990 follow-up) authority heading use in search results should work with ES as well

It seems that the enhancement introduced with bug 29990 (syspref: ShowHeadingUse) works
only with Zebra (generation of main/subject/series use info is made only in
C4::AuthoritiesMarc == a Zebra incarnation of search_auth_compat) and has no effect
on ES search results.

This patch does the same for ES.

Test plan:

1. Have an installation with Elasticsearch enabled.
2. Go to Koha Administration -> system preferences -> searching tab.
   Enable ShowHeadingUse system preference.
3. Do an authority search. Notice that in the Heading use column you get always
   'x' for all use types: main/subject/series.
4. Apply the patch.
5. Do an authority search. Notice that you get now 'v' or 'x' for use types
   main/subject/series, depending on the 008/14-16 bytes.
Comment 2 Roman Dolny 2024-02-13 10:14:35 UTC
Created attachment 162089 [details] [review]
Bug 36069: (bug 29990 follow-up) authority heading use in search results should work with ES as well

It seems that the enhancement introduced with bug 29990 (syspref: ShowHeadingUse) works
only with Zebra (generation of main/subject/series use info is made only in
C4::AuthoritiesMarc == a Zebra incarnation of search_auth_compat) and has no effect
on ES search results.

This patch does the same for ES.

Test plan:

1. Have an installation with Elasticsearch enabled.
2. Go to Koha Administration -> system preferences -> searching tab.
   Enable ShowHeadingUse system preference.
3. Do an authority search. Notice that in the Heading use column you get always
   'x' for all use types: main/subject/series.
4. Apply the patch.
5. Do an authority search. Notice that you get now 'v' or 'x' for use types
   main/subject/series, depending on the 008/14-16 bytes.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Phil Ringnalda 2024-02-13 15:49:14 UTC
The patch in bug 33348 is another fix ahead, and just needs signoff and qa on the unit test

*** This bug has been marked as a duplicate of bug 33348 ***