Bug 36706 - 'Add guarantor' - Patron preview 'close window' does not work
Summary: 'Add guarantor' - Patron preview 'close window' does not work
Status: RESOLVED DUPLICATE of bug 35362
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Pedro Amorim
QA Contact: Testopia
URL:
Keywords:
Depends on: 35329 35362
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-26 09:07 UTC by Pedro Amorim
Modified: 2024-04-30 06:58 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 36706: Fix close button (1.44 KB, patch)
2024-04-26 09:12 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36706: Fix close button (1.49 KB, patch)
2024-04-26 10:41 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-04-26 09:07:07 UTC

    
Comment 1 Pedro Amorim 2024-04-26 09:12:04 UTC
Created attachment 165619 [details] [review]
Bug 36706: Fix close button

1) Visit
http://localhost:8081/cgi-bin/koha/members/memberentry.pl
2) Click 'Search'
3) Click on any cardnumber of any of the search results
4) Click 'close window'. Notice it doesnt close.
5) Apply patch. Repeat test plan.
Comment 2 David Nind 2024-04-26 10:41:18 UTC
Created attachment 165650 [details] [review]
Bug 36706: Fix close button

1) Visit
http://localhost:8081/cgi-bin/koha/members/memberentry.pl
2) Click 'Search'
3) Click on any cardnumber of any of the search results
4) Click 'close window'. Notice it doesnt close.
5) Apply patch. Repeat test plan.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-04-26 10:44:23 UTC
Testing notes (using KTD):

1. Go to add a new patron where guarantors are allowed (Patrons > New patron > Kid)

2. Click the 'Add guarantor' button (under the 'Patron guarantor' section).

3. Click the 'Search' button.

4. Click on any card number in the search results.

5. In the pop-up window with the patron summary details, click on the 'Close window' button.
Comment 4 Pedro Amorim 2024-04-26 11:15:18 UTC
Thanks for the clearer instructions, David, I skipped a few in my test plan. Sorry!
Comment 5 Martin Renvoize 2024-04-30 06:57:37 UTC
Ho.. I fixed this in main already I think.

It wasn't actually 35329 that caused it.. it's bug 35362 and there's a follow-up in there that Katrin pushed I think.

Appologie for the overlap there Pedro
Comment 6 Martin Renvoize 2024-04-30 06:58:46 UTC

*** This bug has been marked as a duplicate of bug 35362 ***