If DefaultHoldPickupLocation is set to logged in library, this should be taken into account when placing multi-holds. To recreate: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup at" and "Pickup location" are empty and the staff member must select the library
Created attachment 166857 [details] [review] Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference
This patch sets the 'Pickup location' according to the DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was unsure how you'd set that to the item's home/holding branch when there are more than 1 holds being placed. I was thinking it would be nice that if you changed 'Pickup at' al the lower 'Pickup location' would also change to what you choose?
(In reply to Lucas Gass from comment #2) > This patch sets the 'Pickup location' according to the > DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was > unsure how you'd set that to the item's home/holding branch when there are > more than 1 holds being placed. That's why I specified "if DefaultHoldPickupLocation is set to logged in library". It should be the same for all holds in that case. The client who reported this to me is a one-branch library and they wanted to avoid having to choose a branch there (I also filed bug 36870 about that). But I figured if their pref is set to logged in library, it would be another way to avoid the extra clicks.
Created attachment 166905 [details] [review] Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Thanks Lucas, I hadn't realized we had to fill either the top or the bottom ones. It works this way and removes the extra click.
Created attachment 171263 [details] [review] Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
I seem to remember a discussion about this when we last touched this code. I think the problem was that the DefaultHoldPickupLocation could be an invalid choice for all or some of the records when placing multiple holds. Has thie been tested or taken into account here? (Failed QA for the question)
But isn't this handled by $biblio->pickup_locations ?
(In reply to Paul Derscheid from comment #8) > But isn't this handled by $biblio->pickup_locations ? Queue is a bit full, so not time for extensive testing. Would be good to verify :)