Bug 36925 - ERM eUsage reports : data table filter does not work
Summary: ERM eUsage reports : data table filter does not work
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-22 12:51 UTC by Michaela Sieber
Modified: 2024-10-01 13:48 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Test file - TR_J1 (505.40 KB, text/csv)
2024-06-06 13:25 UTC, Matt Blenkinsop
Details
Bug 36925: Remove filtering from usage reports (9.86 KB, patch)
2024-06-06 13:26 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Screenshot - Export option NOT visible after the patch is applied (85.93 KB, image/png)
2024-06-08 00:47 UTC, David Nind
Details
Bug 36925: Reinstate export button (3.82 KB, patch)
2024-06-18 14:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36925: Remove filtering from usage reports (9.86 KB, patch)
2024-06-18 14:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36925: Reinstate export button (3.82 KB, patch)
2024-06-18 14:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36925: Remove filtering from usage reports (9.89 KB, patch)
2024-06-18 18:42 UTC, David Nind
Details | Diff | Splinter Review
Bug 36925: Reinstate export button (3.85 KB, patch)
2024-06-18 18:42 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michaela Sieber 2024-05-22 12:51:03 UTC
The data table filter does not work in the ERM module > eUsage > reports 

Just Processing...
but nothing happens
Comment 1 Matt Blenkinsop 2024-06-06 13:25:12 UTC
Created attachment 167544 [details]
Test file - TR_J1
Comment 2 Matt Blenkinsop 2024-06-06 13:26:12 UTC
Created attachment 167545 [details] [review]
Bug 36925: Remove filtering from usage reports

The query behind a usage report is too complex for the datatables filtering options and so should be removed until we can add some datatables utility methods to assist with the filtering

Test plan:
1) Navigate to E-resource management > eUsage > Data providers
2) Create a provider
3) Click into the provider and navigate to the Manual upload tab
4) Upload the file attached
5) Navigate to the Reports section in the left hand menu
6) Run a report that returns some data from the harvested file (report type is TR_J1)
7) Try to filter the table using the filter inputs, it will fail
8) Apply patch
9) Run yarn js:build to rebuild the Javascript
10) Hard refresh the browser
11) The filter options should not not be in the table
Comment 3 Matt Blenkinsop 2024-06-06 13:27:46 UTC
The query behind the reports table is too complex for the datatable filtering so in the short term we need to switch the filtering off. Reports can be exported to excel for filtering / analysis
Comment 4 David Nind 2024-06-08 00:47:03 UTC
Created attachment 167592 [details]
Screenshot - Export option NOT visible after the patch is applied

This works, however the 'Export' button/link is not there after the patch. See the attached screenshot.
Comment 5 Matt Blenkinsop 2024-06-18 14:29:01 UTC
Created attachment 167856 [details] [review]
Bug 36925: Reinstate export button
Comment 6 Matt Blenkinsop 2024-06-18 14:29:35 UTC
Created attachment 167857 [details] [review]
Bug 36925: Remove filtering from usage reports

The query behind a usage report is too complex for the datatables filtering options and so should be removed until we can add some datatables utility methods to assist with the filtering

Test plan:
1) Navigate to E-resource management > eUsage > Data providers
2) Create a provider
3) Click into the provider and navigate to the Manual upload tab
4) Upload the file attached
5) Navigate to the Reports section in the left hand menu
6) Run a report that returns some data from the harvested file (report type is TR_J1)
7) Try to filter the table using the filter inputs, it will fail
8) Apply patch
9) Run yarn js:build to rebuild the Javascript
10) Hard refresh the browser
11) The filter options should not not be in the table
Comment 7 Matt Blenkinsop 2024-06-18 14:29:38 UTC
Created attachment 167858 [details] [review]
Bug 36925: Reinstate export button
Comment 8 David Nind 2024-06-18 18:42:19 UTC
Created attachment 167862 [details] [review]
Bug 36925: Remove filtering from usage reports

The query behind a usage report is too complex for the datatables filtering options and so should be removed until we can add some datatables utility methods to assist with the filtering

Test plan:
1) Navigate to E-resource management > eUsage > Data providers
2) Create a provider
3) Click into the provider and navigate to the Manual upload tab
4) Upload the file attached
5) Navigate to the Reports section in the left hand menu
6) Run a report that returns some data from the harvested file (report type is TR_J1)
7) Try to filter the table using the filter inputs, it will fail
8) Apply patch
9) Run yarn js:build to rebuild the Javascript
10) Hard refresh the browser
11) The filter options should not not be in the table

Signed-off-by: David Nind <david@davidnind.com>
Comment 9 David Nind 2024-06-18 18:42:22 UTC
Created attachment 167863 [details] [review]
Bug 36925: Reinstate export button

Signed-off-by: David Nind <david@davidnind.com>
Comment 10 David Nind 2024-06-18 18:47:08 UTC
One minor note, but wasn't a blocker for me: The Export link is now just after Last >>, rather than aligned to the far right.

Testing notes (using KTD):
1. Details I used for a report (step 6). Go to Reports > Create report and use these values for the options:

   Data display: By year
   Choose data provide: [The provider you created in step 2]
   Choose report: TR_J1....
   Start year: 2020
   End year: 2024
   Select report columns: select all available columns to display

   (I saved the report: enter a name for the report and the "Save report".)
Comment 11 Jonathan Druart 2024-10-01 13:48:22 UTC
What's the problem exactly with the filtering?