Bug 37803 - Add patron notification when a new booking has been created successfully
Summary: Add patron notification when a new booking has been created successfully
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Paul Derscheid
QA Contact: Testopia
URL:
Keywords:
Depends on: 37204
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-02 09:54 UTC by Paul Derscheid
Modified: 2024-09-05 12:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function: bookings

Attachments
Bug 37803: Add patron notification when a new booking has been created successfully (8.41 KB, patch)
2024-09-02 10:43 UTC, Paul Derscheid 		Details | Diff | Splinter Review
Bug 37803: Add patron notification when a new booking has been created successfully (8.63 KB, patch)
2024-09-02 10:46 UTC, Paul Derscheid 		Details | Diff | Splinter Review
Bug 37803: Add patron notification when a new booking has been created successfully (8.63 KB, patch)
2024-09-02 10:46 UTC, Paul Derscheid 		Details | Diff | Splinter Review
Bug 37803: Add patron notification when a new booking has been created successfully (8.68 KB, patch)
2024-09-05 12:41 UTC, Paul Derscheid 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Derscheid 2024-09-02 09:54:50 UTC 
Similarly to notices when a booking has been modified or deleted we should have a notice for a successful creation of a booking for patrons.
Comment 1 Katrin Fischer 2024-09-02 09:58:15 UTC 
I stumbled on the bug description a little - hope this is OK?
Comment 2 Paul Derscheid 2024-09-02 09:59:16 UTC 
Sure, you are right. Copied it from Bug 37204 and doctored it a bit too much.
Comment 3 Paul Derscheid 2024-09-02 10:43:27 UTC 
Created attachment 170933 [details] [review]
Bug 37803: Add patron notification when a new booking has been created successfully
Comment 4 Paul Derscheid 2024-09-02 10:46:20 UTC 
Created attachment 170934 [details] [review]
Bug 37803: Add patron notification when a new booking has been created successfully

To test:
1) Apply the patch
2) Include the sample notice, e.g. run 'reset_all' on ktd
3) Create a booking
4) Look into the borrower notifications
5) Confirm the notice has been generated
6) Run t/db_dependent/Koha/Booking.t
Comment 5 Paul Derscheid 2024-09-02 10:46:58 UTC 
Created attachment 170935 [details] [review]
Bug 37803: Add patron notification when a new booking has been created successfully

To test:
1) Apply the patch
2) Include the sample notice, e.g. run 'reset_all' on ktd
3) Create a booking
4) Look into the borrower notifications
5) Confirm the notice has been generated
6) Run t/db_dependent/Koha/Booking.t
Comment 6 Paul Derscheid 2024-09-02 10:47:25 UTC 
Commented the 'Obsoletes' for some reason the first time. Please ignore :D
Comment 7 Paul Derscheid 2024-09-05 12:41:18 UTC 
Created attachment 171066 [details] [review]
Bug 37803: Add patron notification when a new booking has been created successfully

To test:
1) Apply the patch
2) Include the sample notice, e.g. run 'reset_all' on ktd
3) Create a booking
4) Look into the borrower notifications
5) Confirm the notice has been generated
6) Run t/db_dependent/Koha/Booking.t

Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Comment 8 Paul Derscheid 2024-09-05 12:42:12 UTC 
I just inserted the signed-off line because the sandbox failed at that step.
Just for reference.