To recreate: 1 - Create an active and inactive budget in acquisitions 2 - Add funs to both 3 - Visit - Acquisitions -> Suggestions 4 - Click 'Acquisition information' under filters on the left 5 - Note all funds are showing
Created attachment 168459 [details] [review] Bug 37246: Use the same dropdown for filtering and editing/adding budgets This patch removes a second fetch of budgets form the db, and clones the dropdown in the template as we will only ever be displaying one of them at a time. The JS is moved to fire for both operations. To test: 1 - Create an active and inactive budget in acquisitions 2 - Add funds to both 3 - Visit - Acquisitions -> Suggestions 4 - Click 'Acquisition information' under filters on the left 5 - Note all funds are showing 6 - Apply patch 7 - Reload 8 - Note you only see active budgets 9 - Check the box to show inactive, verify they show 10 - Filter by an inactive budget 11 - Confirm selection remains 12 - Add a suggestion and verify budget dropdown works 13 - Edit the suggestion and verify budget dropdown works
Created attachment 168464 [details] [review] Bug 37246: Use the same dropdown for filtering and editing/adding budgets This patch removes a second fetch of budgets form the db, and clones the dropdown in the template as we will only ever be displaying one of them at a time. The JS is moved to fire for both operations. To test: 1 - Create an active and inactive budget in acquisitions 2 - Add funs to both 3 - Visit - Acquisitions -> Suggestions 4 - Click 'Acquisition information' under filters on the left 5 - Note all funds are showing 6 - Apply patch 7 - Reload 8 - Note you only see active budgets 9 - Check the box to show inactive, verify they show 10 - Filter by an inactive budget 11 - Confirm selection remains 12 - Add a suggestion and verify budget dropdown works 13 - Edit the suggestion and verify budget dropdown works Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 168556 [details] [review] Bug 37246: Use the same dropdown for filtering and editing/adding budgets This patch removes a second fetch of budgets form the db, and clones the dropdown in the template as we will only ever be displaying one of them at a time. The JS is moved to fire for both operations. To test: 1 - Create an active and inactive budget in acquisitions 2 - Add funs to both 3 - Visit - Acquisitions -> Suggestions 4 - Click 'Acquisition information' under filters on the left 5 - Note all funds are showing 6 - Apply patch 7 - Reload 8 - Note you only see active budgets 9 - Check the box to show inactive, verify they show 10 - Filter by an inactive budget 11 - Confirm selection remains 12 - Add a suggestion and verify budget dropdown works 13 - Edit the suggestion and verify budget dropdown works Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 168557 [details] [review] Bug 37246: (QA follow-up) DRY Dropdown If we're using the same dropdown it should be defined once. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06