The suggestions management page includes a filter by fund. On the left side of the page, click Acquisition Information to reveal a Fund dropdown. Prior to Bug 37246, this dropdown included and defaulted to the option of "Any." Bug 37246 wrapped that "ANY" option in "[% IF op == 'save' %]." I don't see why that change was made or what it accomplishes.
Created attachment 177282 [details] [review] Bug 38986: Restore ANY filter on suggestions.ttype To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
Created attachment 177285 [details] [review] Bug 38986: Restore ANY filter on suggestions.ttype To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Created attachment 177473 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion
Figured out what that op=save was for! We should allow Any as a filter, but not as an option when saving a suggestion.
Created attachment 177474 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion
Created attachment 177494 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>