Bug 38986 - Restore "Any" option to purchase suggestion filter by fund
Summary: Restore "Any" option to purchase suggestion filter by fund
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords: regression
Depends on: 37246
Blocks:
  Show dependency treegraph
 
Reported: 2025-01-28 15:38 UTC by Andrew Fuerste-Henry
Modified: 2025-02-03 23:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38986: Restore ANY filter on suggestions.ttype (1.72 KB, patch)
2025-01-28 15:41 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38986: Restore ANY filter on suggestions.ttype (1.78 KB, patch)
2025-01-28 16:22 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38986: Restore Any in fund dropdown on suggestions homepage (1.58 KB, patch)
2025-02-03 18:10 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38986: Restore Any in fund dropdown on suggestions homepage (1.49 KB, patch)
2025-02-03 18:14 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38986: Restore Any in fund dropdown on suggestions homepage (1.55 KB, patch)
2025-02-03 23:56 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-01-28 15:38:18 UTC
The suggestions management page includes a filter by fund. On the left side of the page, click Acquisition Information to reveal a Fund dropdown. Prior to Bug 37246, this dropdown included and defaulted to the option of "Any." Bug 37246 wrapped that "ANY" option in "[% IF op == 'save' %]." I don't see why that change was made or what it accomplishes.
Comment 1 Andrew Fuerste-Henry 2025-01-28 15:41:59 UTC
Created attachment 177282 [details] [review]
Bug 38986: Restore ANY filter on suggestions.ttype

To test:
1 - have two suggestions, one with a fund assigned and one without
2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option
3 - apply patch, reload page
4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
Comment 2 Biblibre Sandboxes 2025-01-28 16:22:01 UTC
Created attachment 177285 [details] [review]
Bug 38986: Restore ANY filter on suggestions.ttype

To test:
1 - have two suggestions, one with a fund assigned and one without
2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option
3 - apply patch, reload page
4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Andrew Fuerste-Henry 2025-02-03 18:10:03 UTC
Created attachment 177473 [details] [review]
Bug 38986: Restore Any in fund dropdown on suggestions homepage

This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion

To test:
1 - have two suggestions, one with a fund assigned and one without
2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option
3 - apply patch, reload page
4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
5 - confirm you cannot select Any when creating a new suggestion
Comment 4 Andrew Fuerste-Henry 2025-02-03 18:11:18 UTC
Figured out what that op=save was for! We should allow Any as a filter, but not as an option when saving a suggestion.
Comment 5 Andrew Fuerste-Henry 2025-02-03 18:14:11 UTC
Created attachment 177474 [details] [review]
Bug 38986: Restore Any in fund dropdown on suggestions homepage

This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion

To test:
1 - have two suggestions, one with a fund assigned and one without
2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option
3 - apply patch, reload page
4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
5 - confirm you cannot select Any when creating a new suggestion
Comment 6 Biblibre Sandboxes 2025-02-03 23:56:44 UTC
Created attachment 177494 [details] [review]
Bug 38986: Restore Any in fund dropdown on suggestions homepage

This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion

To test:
1 - have two suggestions, one with a fund assigned and one without
2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option
3 - apply patch, reload page
4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
5 - confirm you cannot select Any when creating a new suggestion

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>