The suggestions management page includes a filter by fund. On the left side of the page, click Acquisition Information to reveal a Fund dropdown. Prior to Bug 37246, this dropdown included and defaulted to the option of "Any." Bug 37246 wrapped that "ANY" option in "[% IF op == 'save' %]." I don't see why that change was made or what it accomplishes.
Created attachment 177282 [details] [review] Bug 38986: Restore ANY filter on suggestions.ttype To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly
Created attachment 177285 [details] [review] Bug 38986: Restore ANY filter on suggestions.ttype To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Created attachment 177473 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion
Figured out what that op=save was for! We should allow Any as a filter, but not as an option when saving a suggestion.
Created attachment 177474 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion
Created attachment 177494 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Still a bit confused here. I would not expect the same set of values for the filter dropdown and the actual fund field. I think that the filter should always list Any. No selection on fund. And that the fund field should not Any but should have None. Now we are using the same block and that does not work imo.. Please clarify.
I think none would be "no fund set" while "any" means it can be empty or set to any fund - that would make sense to me as a default.
Created attachment 178101 [details] [review] Bug 38986: Restore Any option to suggestions homepage filter "Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any" "None" should show only suggestions with no fund value selected. A new suggestion should default to "None" To Test: 1: have two suggestions, one with a fund selected and one without 2: go to suggestions homepage, confirm the filter does not have an "Any" option 3: apply patch, reload page 4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above 5: confirm the fund filter defaults to Any as you change the branch filter 6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any
(In reply to Marcel de Rooy from comment #7) > Still a bit confused here. > I would not expect the same set of values for the filter dropdown and the > actual fund field. > I think that the filter should always list Any. No selection on fund. > And that the fund field should not Any but should have None. > Now we are using the same block and that does not work imo.. > > Please clarify. Agreed, using the same form for creation and filtering made this weird! I realized I'd made "None" disappear from the filter. New patch corrects that and clarifies expectations in the test plan. Thanks!
Created attachment 178139 [details] [review] Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Bug 38986: Restore Any option to suggestions homepage filter "Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any" "None" should show only suggestions with no fund value selected. A new suggestion should default to "None" To Test: 1: have two suggestions, one with a fund selected and one without 2: go to suggestions homepage, confirm the filter does not have an "Any" option 3: apply patch, reload page 4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above 5: confirm the fund filter defaults to Any as you change the branch filter 6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Since this is marked trivial and tested before, I will continue passing QA now. Have squashed both patches in the process.
Pushed for 25.05! Well done everyone, thank you!
Rmaints, please backport this to 24.11 and 24.05 as it creates confusion for users. Thanks!
Nice work everyone! Pushed to 24.11.x for 24.11.03