Bug 38698 - Created by filter in acquisitions duplicate orders search always shows zero results
Summary: Created by filter in acquisitions duplicate orders search always shows zero r...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Brendan Lawlor
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-13 14:57 UTC by Brendan Lawlor
Modified: 2025-04-14 10:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Basket created by" search when duplicating existing orders in acquisitions - it now returns results, previously no results were returned.
Version(s) released in:
25.05.00,24.11.04
Circulation function:


Attachments
Bug 38698: Fix Acquisitions duplicate orders search (1.65 KB, patch)
2024-12-13 15:16 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 38698: Fix Acquisitions duplicate orders search (1.70 KB, patch)
2024-12-28 20:09 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Lawlor 2024-12-13 14:57:59 UTC
This is like bug 37304 but for the duplicate orders search.

To replicate:
1. Add a vendor, stage a record for import and add an order to a basket
2. Add another basket and add an order using From existing orders (copy)
3. On the Duplicate existing orders page search Basket created by: for 'koha'
4. No results appear :(
Comment 1 Brendan Lawlor 2024-12-13 15:16:55 UTC
Created attachment 175449 [details] [review]
Bug 38698: Fix Acquisitions duplicate orders search

This patch updates the field for the created by filter from
ui.item.borrowernumber to ui.item.patron_id

To test:

1. Add a vendor and a basket
2. Stage a file and add an order to the basket
3. Add another basket and add an order using From existing orders (copy)
4. On the Duplicate existing orders page search for Basket created by: 'koha'
5. No results appear :(
6. Apply patch and repeat steps 3 and 4
6. Confirm the search returns the basket you created earlier
Comment 2 David Nind 2024-12-28 20:09:21 UTC
Created attachment 175970 [details] [review]
Bug 38698: Fix Acquisitions duplicate orders search

This patch updates the field for the created by filter from
ui.item.borrowernumber to ui.item.patron_id

To test:

1. Add a vendor and a basket
2. Stage a file and add an order to the basket
3. Add another basket and add an order using From existing orders (copy)
4. On the Duplicate existing orders page search for Basket created by: 'koha'
5. No results appear :(
6. Apply patch and repeat steps 3 and 4
6. Confirm the search returns the basket you created earlier

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2024-12-30 10:39:28 UTC
Easy fix, thanks Breandan! QA by RM.
Comment 4 Katrin Fischer 2024-12-30 11:10:18 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2025-04-14 10:07:00 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.04