Bug 37385 - Transfer/next hold modals not triggered automatically when cancelling a hold by checking item in
Summary: Transfer/next hold modals not triggered automatically when cancelling a hold ...
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Kyle M Hall (khall)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
: 37347 (view as bug list)
Depends on:
Blocks: 36192
  Show dependency tree / graph
 
Reported: 2024-07-16 20:58 UTC by Heather Rommens
Modified: 2024-11-14 14:38 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes an issue when checking in an item to cancel a waiting hold - if a transfer to the originating library is required, the pop-up window notifying that a transfer is required was not automatically generated. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
Version(s) released in:
24.11.00,24.05.02
Circulation function:

Attachments
Bug 37385: Transfer not triggered automatically when cancelling a hold by checking item in (edit) (1.32 KB, patch)
2024-07-18 13:04 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 37385: Transfer not triggered automatically when cancelling a hold by checking item in (edit) (1.37 KB, patch)
2024-07-18 13:16 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item (1.38 KB, patch)
2024-07-18 17:55 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item (1.45 KB, patch)
2024-07-18 19:47 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Heather Rommens 2024-07-16 20:58:36 UTC 
When I check in an item to cancel a waiting hold on an item from another library, the transfer message doesn't pop up to return item to its home library after the hold is cancelled. 
In previous versions, the steps would be:
-Find item with a waiting hold, and check it in
-On the popup notifying me of the waiting hold, select 'Cancel hold'
-A second popup appears notifying me of the need to transfer the item to its home library, which I could confirm or cancel.

The second popup is no longer appearing. I have to check the item in a second time to trigger the transfer.
Comment 1 Kyle M Hall (khall) 2024-07-18 13:04:44 UTC 
Created attachment 169132 [details] [review]
Bug 37385: Transfer not triggered automatically when cancelling a hold by checking item in (edit)

Upadates for CSRF are inadvertently stopping AddReturn from being trigger
when a hold is canceled. This is necessary to generate the transfer
back to the originating library.

Test Plan:
1) Find item with a waiting hold, and check it in
2) In the popup notifying me of the waiting hold, select 'Cancel hold'
3) Note no second popup appears notifying you of the need to transfer the item to its home library
4) Apply this patch
5) Restart all the things!
6) Repeat steps 1-2
7) Second popup appears!
Comment 2 Lucas Gass (lukeg) 2024-07-18 13:16:37 UTC 
Created attachment 169134 [details] [review]
Bug 37385: Transfer not triggered automatically when cancelling a hold by checking item in (edit)

Upadates for CSRF are inadvertently stopping AddReturn from being trigger
when a hold is canceled. This is necessary to generate the transfer
back to the originating library.

Test Plan:
1) Find item with a waiting hold, and check it in
2) In the popup notifying me of the waiting hold, select 'Cancel hold'
3) Note no second popup appears notifying you of the need to transfer the item to its home library
4) Apply this patch
5) Restart all the things!
6) Repeat steps 1-2
7) Second popup appears!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Lucas Gass (lukeg) 2024-07-18 13:18:34 UTC 
This fix also fixes a similar issue reported in Bug 37347. I have changed this bug title to reflect that and will resolve 37347 as a duplicate of this one.

Thank you, Kyle!
Comment 4 Lucas Gass (lukeg) 2024-07-18 13:19:10 UTC 
*** Bug 37347 has been marked as a duplicate of this bug. ***
Comment 5 Kyle M Hall (khall) 2024-07-18 17:55:03 UTC 
Created attachment 169161 [details] [review]
Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item

Upadates for CSRF are inadvertently stopping AddReturn from being trigger
when a hold is canceled. This is necessary to generate the transfer
back to the originating library.

Test Plan:
1) Find item with a waiting hold, and check it in
2) In the popup notifying me of the waiting hold, select 'Cancel hold'
3) Note no second popup appears notifying you of the need to transfer the item to its home library
4) Apply this patch
5) Restart all the things!
6) Repeat steps 1-2
7) Second popup appears!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Emily Lamancusa (emlam) 2024-07-18 19:47:08 UTC 
Created attachment 169166 [details] [review]
Bug 37385: Fix Transfer not triggering automatically when cancelling a hold by checking in an item

Upadates for CSRF are inadvertently stopping AddReturn from being trigger
when a hold is canceled. This is necessary to generate the transfer
back to the originating library.

Test Plan:
1) Find item with a waiting hold, and check it in
2) In the popup notifying me of the waiting hold, select 'Cancel hold'
3) Note no second popup appears notifying you of the need to transfer the item to its home library
4) Apply this patch
5) Restart all the things!
6) Repeat steps 1-2
7) Second popup appears!

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa (emlam) 2024-07-18 19:47:59 UTC 
The patch makes sense and fixes the regression, and QA tool passes. Passing QA

As a side note, I don't love that we call AddReturn again to initiate the next action after canceling a hold. At the very least, in inflates the local use count if RecordLocalUseOnReturn is on - not sure if it introduces other side effects in that situation as well. That's a separate issue that has been there for a while, though.
Comment 8 Martin Renvoize (ashimema) 2024-07-22 06:38:14 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 9 Lucas Gass (lukeg) 2024-07-24 20:15:54 UTC 
Backported to 24.05.x for upcoming 24.05.02
Comment 10 Fridolin Somers 2024-07-25 07:57:18 UTC 
Full CSRF not in 23.11.x