Bug 37444 - Can't filter holds to pull by pickup location
Summary: Can't filter holds to pull by pickup location
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Peter Vashchuk
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-24 04:29 UTC by Peter Vashchuk
Modified: 2024-11-18 18:40 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 37444: Fix filter for Pickup Location (1.61 KB, patch)
2024-07-24 04:31 UTC, Peter Vashchuk 		Details | Diff | Splinter Review
Bug 37444: Fix filter for Pickup Location (1.66 KB, patch)
2024-07-24 14:40 UTC, Eric Garcia 		Details | Diff | Splinter Review
Bug 37444: Fix filter for Pickup Location (1.73 KB, patch)
2024-07-25 14:30 UTC, Laura Escamilla 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Vashchuk 2024-07-24 04:29:24 UTC 

    


    


      



        
          Comment 1
        

        
          Peter Vashchuk

        

        
        

        
          2024-07-24 04:31:50 UTC
        

      






Created attachment 169449 [details] [review]
Bug 37444: Fix filter for Pickup Location

When trying to filter holds to pull using the dropdown filter for Pickup Location, the dropdown has "None" as the only available option because of incorrect column index in ppendingreserves.tt

To reproduce:
1. Place a hold and go to Circulation -> Holds to pull.
2. Use a dropdown filter for Pickup Location, see that only "None" is available to pick, meaning you can't use the filter.
3. Apply the patch.
4. Do the step 2 again and ensure that there's also an option for that hold's pickup location.

    


    


      



        
          Comment 2
        

        
          Eric Garcia

        

        
        

        
          2024-07-24 14:40:53 UTC
        

      






Created attachment 169496 [details] [review]
Bug 37444: Fix filter for Pickup Location

When trying to filter holds to pull using the dropdown filter for Pickup Location, the dropdown has "None" as the only available option because of incorrect column index in ppendingreserves.tt

To reproduce:
1. Place a hold and go to Circulation -> Holds to pull.
2. Use a dropdown filter for Pickup Location, see that only "None" is available to pick, meaning you can't use the filter.
3. Apply the patch.
4. Do the step 2 again and ensure that there's also an option for that hold's pickup location.

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>

    


    


      



        
          Comment 3
        

        
          Laura Escamilla

        

        
        

        
          2024-07-25 14:30:45 UTC
        

      






Created attachment 169560 [details] [review]
Bug 37444: Fix filter for Pickup Location

Nice trivial patch, no QA issues. Passing QA

Signed-off-by: Eric Garcia <cubingguy714@gmail.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>

    


    


      



        
          Comment 4
        

        
          Katrin Fischer

        

        
        

        
          2024-08-09 15:37:08 UTC
        

      






Pushed for 24.11!

Well done everyone, thank you!

    


    


      



        
          Comment 5
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2024-11-18 18:40:42 UTC
        

      






Backported to 24.05.x for upcoming 24.05.06