After applying bug 32693 the Elasticsearch checks are performed only for 'System information' tab (About Koha section). As the result, information about Elasticsearch status is missing from the main tab (Server information). Only misleading empty "Version: | Nodes: | Status: not running" info is shown. The Elasticsearch checks should be (as a whole or in relevant fragments) performed both for "about" and "sysinfo" $tab(s).
Created attachment 169822 [details] [review] Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs 1) Notice 'Elasticsearch:' entry at http://localhost:8081/cgi-bin/koha/about.pl?tab=about is empty 2) Apply patch + restart plack 3) Repeat step 1) Notice it now shows elasticsearch info as expected. 4) Verify that Elasticsearch warning http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo is the same before and applying patch.
Adding Joubu as QA contact here as this is a similar bug to bug 37260.
To test, run: $ ktd --es8 up
Created attachment 169825 [details] [review] Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs 1) Notice 'Elasticsearch:' entry at http://localhost:8081/cgi-bin/koha/about.pl?tab=about is empty 2) Apply patch + restart plack 3) Repeat step 1) Notice it now shows elasticsearch info as expected. 4) Verify that Elasticsearch warning http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo is the same before and applying patch. Signed-off-by: David Nind <david@davidnind.com>
*** Bug 37170 has been marked as a duplicate of this bug. ***
Created attachment 170529 [details] [review] Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs 1) Notice 'Elasticsearch:' entry at http://localhost:8081/cgi-bin/koha/about.pl?tab=about is empty 2) Apply patch + restart plack 3) Repeat step 1) Notice it now shows elasticsearch info as expected. 4) Verify that Elasticsearch warning http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo is the same before and applying patch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple patch, works as described.. Passing QA
Pushed for 24.11! Well done everyone, thank you!
this needs to be backported to 24.05
*** Bug 37798 has been marked as a duplicate of this bug. ***
Backporteed to 24.05.x for upcoming 24.05.04
Depends on Bug 32693 not in 23.11.x