Bug 37509 - Elasticsearch status info missing from 'Server information'
Summary: Elasticsearch status info missing from 'Server information'
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Pedro Amorim
QA Contact: Martin Renvoize
URL:
Keywords:
: 37170 37798 (view as bug list)
Depends on: 32693
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-29 10:17 UTC by Janusz Kaczmarek
Modified: 2024-09-06 20:55 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the About Koha > Server information page so that it now shows information about Elasticsearch. Before this, it was empty.
Version(s) released in:
24.11.00,24.05.04
Circulation function:


Attachments
Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs (7.68 KB, patch)
2024-07-29 11:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs (7.73 KB, patch)
2024-07-29 11:32 UTC, David Nind
Details | Diff | Splinter Review
Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs (7.80 KB, patch)
2024-08-21 08:11 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-07-29 10:17:45 UTC
After applying bug 32693 the Elasticsearch checks are performed only for 'System information' tab (About Koha section).  As the result, information about Elasticsearch status is missing from the main tab (Server information).  Only misleading empty "Version: | Nodes: | Status: not running" info is shown.

The Elasticsearch checks should be (as a whole or in relevant fragments) performed both for "about" and "sysinfo" $tab(s).
Comment 1 Pedro Amorim 2024-07-29 11:24:01 UTC
Created attachment 169822 [details] [review]
Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs

1) Notice 'Elasticsearch:' entry at  http://localhost:8081/cgi-bin/koha/about.pl?tab=about is empty
2) Apply patch + restart plack
3) Repeat step 1) Notice it now shows elasticsearch info as expected.
4) Verify that Elasticsearch warning http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo is the same before and applying patch.
Comment 2 Pedro Amorim 2024-07-29 11:24:57 UTC
Adding Joubu as QA contact here as this is a similar bug to bug 37260.
Comment 3 Pedro Amorim 2024-07-29 11:28:54 UTC
To test, run:
$ ktd --es8 up
Comment 4 David Nind 2024-07-29 11:32:16 UTC
Created attachment 169825 [details] [review]
Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs

1) Notice 'Elasticsearch:' entry at  http://localhost:8081/cgi-bin/koha/about.pl?tab=about is empty
2) Apply patch + restart plack
3) Repeat step 1) Notice it now shows elasticsearch info as expected.
4) Verify that Elasticsearch warning http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo is the same before and applying patch.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Janusz Kaczmarek 2024-07-30 10:37:15 UTC
*** Bug 37170 has been marked as a duplicate of this bug. ***
Comment 6 Martin Renvoize 2024-08-21 08:11:06 UTC
Created attachment 170529 [details] [review]
Bug 37509: Check elasticsearch info for both 'about' and 'sysinfo' tabs

1) Notice 'Elasticsearch:' entry at  http://localhost:8081/cgi-bin/koha/about.pl?tab=about is empty
2) Apply patch + restart plack
3) Repeat step 1) Notice it now shows elasticsearch info as expected.
4) Verify that Elasticsearch warning http://localhost:8081/cgi-bin/koha/about.pl?tab=sysinfo is the same before and applying patch.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2024-08-21 08:11:37 UTC
Simple patch, works as described.. Passing QA
Comment 8 Katrin Fischer 2024-08-21 17:15:24 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 9 Blou 2024-08-30 12:54:29 UTC
this needs to be backported to 24.05
Comment 10 Aleisha Amohia 2024-09-02 20:46:34 UTC
*** Bug 37798 has been marked as a duplicate of this bug. ***
Comment 11 Lucas Gass 2024-09-06 16:53:41 UTC
Backporteed to 24.05.x for upcoming 24.05.04