Bug 37546 - We should output error messages alongside error codes for z39.50 errors
Summary: We should output error messages alongside error codes for z39.50 errors
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: David Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-01 15:34 UTC by Martin Renvoize (ashimema)
Modified: 2024-11-06 17:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 37546: Output error message from ZOOM in Z3950 errors (2.44 KB, patch)
2024-08-01 15:38 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-08-01 15:34:06 UTC 
When performing a z39.50 search during cataloging, there are various errors that can be returned from ZOOM.. these have errors codes, but they also have nicer strings too.. which we're hiding!

We should return both in the result.
Comment 1 Martin Renvoize (ashimema) 2024-08-01 15:38:33 UTC 
Created attachment 169953 [details] [review]
Bug 37546: Output error message from ZOOM in Z3950 errors
Comment 2 Owen Leonard 2024-08-02 14:54:40 UTC 
How does one test this?
Comment 3 David Cook 2024-10-24 06:39:53 UTC 
Ohh I am curious about this as well
Comment 4 Martin Renvoize (ashimema) 2024-11-06 17:29:52 UTC 
I found this whilst hitting a Z39.50 server that was misconfigured somewhere.. it's since working so I'm not able to offer a simple test plan.. 

The code is simple to read however.. we're just grabbing the message as well as the code now and displaying where we once only displayed the error code.

It makes debugging Z connections easier basically.