Created attachment 171097 [details] Screenshot of the Run with template drop-down This seems to be the same problem as Bug 36157, but maybe related to the bootstrap upgrade? To replicate (copied from bug 36157): 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from the other bug: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and hover the template title. I attached a screenshot of what it looks like in my ktd (Chrome on Ubuntu 22.04).
Created attachment 171132 [details] [review] Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries
Created attachment 171135 [details] [review] Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 172268 [details] [review] Bug 37848: Fix "Run with template" dropdown menu style This patch adds the missing "dropdown-item" class to the "Run with template" dropdown menu markup in order to correct the menu's style. The patch also adds a template ID to the menu items' id attributes so that we don't have duplicate IDs. To test, apply the patch and go to Tools -> Notices. (testing steps copied from Bug 36157) 1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug: [% FOREACH b IN data %] <div class="panel panel-default"> <div class="panel-heading">[% b.surname %], [% b.firstname %]</div> <div class="panel-body">Expiration: [% b.dateexpiry %]</div> <div class="panel-footer">ID: [% b.borrowernumber %]</div> </div> [% END %] 2. Create and run a saved report. Example from bug 36157: SELECT * FROM borrowers 3. Click on the "Run with template" dropdown and confirm that it is styled correctly. 4. Click to run the report with the template and confirm that it works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant