Bug 37848 - "Run with template" options need formatting
Summary: "Run with template" options need formatting
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-05 16:39 UTC by Caroline Cyr La Rose
Modified: 2024-09-06 13:03 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Screenshot of the Run with template drop-down (40.58 KB, image/png)
2024-09-05 16:39 UTC, Caroline Cyr La Rose
Details
Bug 37848: Fix "Run with template" dropdown menu style (2.35 KB, patch)
2024-09-06 11:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37848: Fix "Run with template" dropdown menu style (2.42 KB, patch)
2024-09-06 13:03 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-09-05 16:39:05 UTC
Created attachment 171097 [details]
Screenshot of the Run with template drop-down

This seems to be the same problem as Bug 36157, but maybe related to the bootstrap upgrade?

To replicate (copied from bug 36157):

1. Create a notice with the module of "Reports" -- add something to the "Print" section. Example from the other bug:

[% FOREACH b IN data %]
<div class="panel panel-default">
  <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
  <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
  <div class="panel-footer">ID: [% b.borrowernumber %]</div>
</div>
[% END %]

2. Create and run a saved report. Example from the other bug:

SELECT * FROM borrowers

3. Click on the "Run with template" dropdown and hover the template title.

I attached a screenshot of what it looks like in my ktd (Chrome on Ubuntu 22.04).
Comment 1 Owen Leonard 2024-09-06 11:49:53 UTC
Created attachment 171132 [details] [review]
Bug 37848: Fix "Run with template" dropdown menu style

This patch adds the missing "dropdown-item" class to the "Run with
template" dropdown menu markup in order to correct the menu's style.

The patch also adds a template ID to the menu items' id attributes so
that we don't have duplicate IDs.

To test, apply the patch and go to Tools -> Notices.

(testing steps copied from Bug 36157)

1. Create a notice with the module of "Reports" -- add something to the
   "Print" section. Example from the other bug:

    [% FOREACH b IN data %]
      <div class="panel panel-default">
         <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
         <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
         <div class="panel-footer">ID: [% b.borrowernumber %]</div>
      </div>
    [% END %]

2. Create and run a saved report. Example from bug 36157:

    SELECT * FROM borrowers

3. Click on the "Run with template" dropdown and confirm that it is
   styled correctly.
4. Click to run the report with the template and confirm that it works
   correctly.

Sponsored-by: Athens County Public Libraries
Comment 2 Caroline Cyr La Rose 2024-09-06 13:03:56 UTC
Created attachment 171135 [details] [review]
Bug 37848: Fix "Run with template" dropdown menu style

This patch adds the missing "dropdown-item" class to the "Run with
template" dropdown menu markup in order to correct the menu's style.

The patch also adds a template ID to the menu items' id attributes so
that we don't have duplicate IDs.

To test, apply the patch and go to Tools -> Notices.

(testing steps copied from Bug 36157)

1. Create a notice with the module of "Reports" -- add something to the
   "Print" section. Example from the other bug:

    [% FOREACH b IN data %]
      <div class="panel panel-default">
         <div class="panel-heading">[% b.surname %], [% b.firstname %]</div>
         <div class="panel-body">Expiration: [% b.dateexpiry %]</div>
         <div class="panel-footer">ID: [% b.borrowernumber %]</div>
      </div>
    [% END %]

2. Create and run a saved report. Example from bug 36157:

    SELECT * FROM borrowers

3. Click on the "Run with template" dropdown and confirm that it is
   styled correctly.
4. Click to run the report with the template and confirm that it works
   correctly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>