Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices.
Created attachment 171791 [details] [review] Bug 37967 - Allow auto renewals notices to be sent via phone
Created attachment 171792 [details] [review] Bug 37967 - Allow auto renewals notices to be sent via phone Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note you can now select phone for auto-renewals!
Created attachment 171808 [details] [review] Bug 37967 - Allow auto renewals notices to be sent via phone Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note you can now select phone for auto-renewals! Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Set the PhoneNotification system preerence to 'Enable'. 2. View a patron's details (the Details section) 3. Note that there is now a phone column in the 'Patron messaging preferences' section, but for 'Auto renewal' there is no checkbox. 4. Apply the patch. 5. Update the database: updatedatabase 6. Restart everything: restart_all 7. Refresh the page. 8. If you edit the patron's messaging preferences, you can now select phone as an option. 9. If you edit a patron category, you can also now select phone as an option. Note: I have no way of actually sending a phone message, so couldn't test that.
Created attachment 171950 [details] [review] Bug 37967: Allow auto renewals notices to be sent via phone Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Note you can now select phone for auto-renewals! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 171951 [details] [review] Bug 37967: (QA follow-up) Add bug number/description and perltidy atomicupdate Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
We should not try catch without rethrow. Please adjust the db rev: Simply remove the try-catch block. See bug 37895 for more details.
(In reply to Jonathan Druart from comment #8) > We should not try catch without rethrow. Please adjust the db rev: Simply > remove the try-catch block. > > See bug 37895 for more details. See bug 38394.