Bug 37967 - Allow auto renewals notices to be sent via phone
Summary: Allow auto renewals notices to be sent via phone
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Kyle M Hall (khall)
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-19 18:28 UTC by Kyle M Hall (khall)
Modified: 2024-11-18 22:47 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37967 - Allow auto renewals notices to be sent via phone (2.44 KB, patch)
2024-09-19 18:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 37967 - Allow auto renewals notices to be sent via phone (2.77 KB, patch)
2024-09-19 18:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 37967 - Allow auto renewals notices to be sent via phone (2.80 KB, patch)
2024-09-19 21:32 UTC, David Nind
Details | Diff | Splinter Review
Bug 37967: Allow auto renewals notices to be sent via phone (2.86 KB, patch)
2024-09-24 19:34 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37967: (QA follow-up) Add bug number/description and perltidy atomicupdate (1.69 KB, patch)
2024-09-24 19:34 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2024-09-19 18:28:18 UTC
Auto renewals via phone are only disallowed because itiva did not support them. There is no reason to disallow auto-reneals for the generic phone transport. Twilio, for example, would have no problem sending those phone notices.
Comment 1 Kyle M Hall (khall) 2024-09-19 18:38:23 UTC
Created attachment 171791 [details] [review]
Bug 37967 - Allow auto renewals notices to be sent via phone
Comment 2 Kyle M Hall (khall) 2024-09-19 18:39:28 UTC
Created attachment 171792 [details] [review]
Bug 37967 - Allow auto renewals notices to be sent via phone

Auto renewals via phone are only disallowed because itiva did not support them.
There is no reason to disallow auto-reneals for the generic phone transport.
Twilio, for example, would have no problem sending those phone notices.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Note you can now select phone for auto-renewals!
Comment 3 David Nind 2024-09-19 21:32:51 UTC
Created attachment 171808 [details] [review]
Bug 37967 - Allow auto renewals notices to be sent via phone

Auto renewals via phone are only disallowed because itiva did not support them.
There is no reason to disallow auto-reneals for the generic phone transport.
Twilio, for example, would have no problem sending those phone notices.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Note you can now select phone for auto-renewals!

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-09-19 21:34:07 UTC
Testing notes (using KTD):
1. Set the PhoneNotification system preerence to 'Enable'.
2. View a patron's details (the Details section)
3. Note that there is now a phone column in the 'Patron messaging preferences' section, but for 'Auto renewal' there is no checkbox.
4. Apply the patch.
5. Update the database: updatedatabase
6. Restart everything: restart_all
7. Refresh the page.
8. If you edit the patron's messaging preferences, you can now select phone as an option.
9. If you edit a patron category, you can also now select phone as an option.

Note: I have no way of actually sending a phone message, so couldn't test that.
Comment 5 Lucas Gass (lukeg) 2024-09-24 19:34:20 UTC
Created attachment 171950 [details] [review]
Bug 37967: Allow auto renewals notices to be sent via phone

Auto renewals via phone are only disallowed because itiva did not support them.
There is no reason to disallow auto-reneals for the generic phone transport.
Twilio, for example, would have no problem sending those phone notices.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Note you can now select phone for auto-renewals!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Lucas Gass (lukeg) 2024-09-24 19:34:23 UTC
Created attachment 171951 [details] [review]
Bug 37967: (QA follow-up) Add bug number/description and perltidy atomicupdate

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 7 Martin Renvoize (ashimema) 2024-10-02 09:56:42 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 8 Jonathan Druart 2024-11-07 09:27:22 UTC
We should not try catch without rethrow. Please adjust the db rev: Simply remove the try-catch block.

See bug 37895 for more details.
Comment 9 Jonathan Druart 2024-11-07 14:31:43 UTC
(In reply to Jonathan Druart from comment #8)
> We should not try catch without rethrow. Please adjust the db rev: Simply
> remove the try-catch block.
> 
> See bug 37895 for more details.

See bug 38394.