The holdings table removes empty columns when loading the first page via API, however, it does not restore them when items are searched or paged To recreate: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is no callnumebr or actions/edit colum 9 - Go to page 2 of items - no callnumber visible though fairview items have them 10 - Go to page 3 - no edit column, though you should be able to edit
Created attachment 172526 [details] [review] Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column
Created attachment 172541 [details] [review] Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
It works! :) Assuming that's expected to have now the Checkouts, Renewals, Local uses now be visible also. ----- > 8 - Note there is callnumber and actions/edit columns Not on page 1, I assume step 9 et 10 take precedence on this.
Created attachment 172583 [details] [review] Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
Needs rebased for 24.05.x
Created attachment 174763 [details] [review] [24.05] Bug 38118: Display columns if not empty in drawCallback Instead of updating only when DT init is complete we are going to update the visibility when the table will be redrawn. Test plan: 1 - Find/Add a bib record with no items 2 - Add 20 items from Centerville Edit ->Edit items -> enter CENTER1 into barcode ->'Add multiple copies' -> 20 3 - Add 20 items from Fairview as above but enter 'FAIR1' for barcode and 'FAIR ITEM' as callnumber 4 - Add 1 item from Midway with barcode MIDWAY1 5 - Edit a midway patron to grant 'catalogue' and 'edit_items' permission - NOT edit_any_item 6 - Sign in as the patron above 7 - Find the record 8 - Note there is callnumber and actions/edit columns 9 - Go to page 2 of items - callnumber visible 10 - Go to page 3 - edit column
(In reply to Lucas Gass (lukeg) from comment #6) > Needs rebased for 24.05.x Done but haven't tested it.
(In reply to Jonathan Druart from comment #8) > (In reply to Lucas Gass (lukeg) from comment #6) > > Needs rebased for 24.05.x > > Done but haven't tested it. And don't forget bug 38240.
Backported to 24.05.x for upcomign 24.05.06
Depends on Bug 33568 not in 23.11.x