Bug 38127 - Missing column headings in 'Add user' pop-up modal
Summary: Missing column headings in 'Add user' pop-up modal
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 35329
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-08 18:45 UTC by Caroline Cyr La Rose
Modified: 2025-06-19 08:55 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the "Add user" pop-up window when adding a user to a new order in acquisitions. The table now shows the column headings, such as card, name, category, and library.
Version(s) released in:
25.11.00,25.05.01,24.11.06
Circulation function:


Attachments
Bug 38127: Missing column headings in 'Add user' pop-up modal (1.72 KB, patch)
2025-05-17 15:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38127: Missing column headings in 'Add user' pop-up modal (1.77 KB, patch)
2025-05-17 19:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 38127: Missing column headings in 'Add user' pop-up modal (1.82 KB, patch)
2025-05-23 12:49 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-10-08 18:45:28 UTC
In the 'Add user' pop-up modal, the column headings in the results are missing. 

To get there (with ktd data):
1. Go to Acquisitions 
2. Click 'Search' to find 'My vendor'
3. Click 'My basket'
4. Click 'Add to basket'
5. Click 'From a new (empty) record'
6. Click 'Add user'
7. Search for 'alford' (for example)
   --> Note that there aren't any column headings in the results

Compare with:
1. Go to Tools > Patron card creator
2. Click 'New' > 'Card batch'
3. Click 'Add patron(s)'
4. Search for 'alford' (for example)
   --> Note that there are column headings in this pop-up

I get that they are different modals (Add user vs Add patrons), but I just wanted to highlight the column headings. I found this while documenting Bug 35329, but I'm not sure if it's related directly to that one.
Comment 1 Owen Leonard 2025-05-17 15:00:06 UTC
Created attachment 182561 [details] [review]
Bug 38127: Missing column headings in 'Add user' pop-up modal

This patch modifies the template for adding to a basket from a new
(empty) record in order to make the "Add user" patron search results
correct. The patron search results table headers must be defined in the
template before they are used.

To test, apply the patch and go to Acquisitions.

- Search for a vendor.
- Add or create a basket for that vendor.
- Click "Add to basket" and select "From a new (empty) record."
- In the "New order" form, under the "Patrons" heading, click "Add user"
- Search for patrons to add.
- In the patron search results, each column should have a heading: Card,
  Name, Category, Library.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2025-05-17 19:00:26 UTC
Created attachment 182562 [details] [review]
Bug 38127: Missing column headings in 'Add user' pop-up modal

This patch modifies the template for adding to a basket from a new
(empty) record in order to make the "Add user" patron search results
correct. The patron search results table headers must be defined in the
template before they are used.

To test, apply the patch and go to Acquisitions.

- Search for a vendor.
- Add or create a basket for that vendor.
- Click "Add to basket" and select "From a new (empty) record."
- In the "New order" form, under the "Patrons" heading, click "Add user"
- Search for patrons to add.
- In the patron search results, each column should have a heading: Card,
  Name, Category, Library.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Julian Maurice 2025-05-23 12:49:16 UTC
Created attachment 182770 [details] [review]
Bug 38127: Missing column headings in 'Add user' pop-up modal

This patch modifies the template for adding to a basket from a new
(empty) record in order to make the "Add user" patron search results
correct. The patron search results table headers must be defined in the
template before they are used.

To test, apply the patch and go to Acquisitions.

- Search for a vendor.
- Add or create a basket for that vendor.
- Click "Add to basket" and select "From a new (empty) record."
- In the "New order" form, under the "Patrons" heading, click "Add user"
- Search for patrons to add.
- In the patron search results, each column should have a heading: Card,
  Name, Category, Library.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Lucas Gass (lukeg) 2025-06-02 20:58:27 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Fridolin Somers 2025-06-18 13:09:16 UTC
I see in 25.05.x
Comment 6 Fridolin Somers 2025-06-18 13:18:27 UTC
Pushed to 24.11.x for 24.11.06
Comment 7 Paul Derscheid 2025-06-19 08:55:07 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03