In the 'Add user' pop-up modal, the column headings in the results are missing. To get there (with ktd data): 1. Go to Acquisitions 2. Click 'Search' to find 'My vendor' 3. Click 'My basket' 4. Click 'Add to basket' 5. Click 'From a new (empty) record' 6. Click 'Add user' 7. Search for 'alford' (for example) --> Note that there aren't any column headings in the results Compare with: 1. Go to Tools > Patron card creator 2. Click 'New' > 'Card batch' 3. Click 'Add patron(s)' 4. Search for 'alford' (for example) --> Note that there are column headings in this pop-up I get that they are different modals (Add user vs Add patrons), but I just wanted to highlight the column headings. I found this while documenting Bug 35329, but I'm not sure if it's related directly to that one.
Created attachment 182561 [details] [review] Bug 38127: Missing column headings in 'Add user' pop-up modal This patch modifies the template for adding to a basket from a new (empty) record in order to make the "Add user" patron search results correct. The patron search results table headers must be defined in the template before they are used. To test, apply the patch and go to Acquisitions. - Search for a vendor. - Add or create a basket for that vendor. - Click "Add to basket" and select "From a new (empty) record." - In the "New order" form, under the "Patrons" heading, click "Add user" - Search for patrons to add. - In the patron search results, each column should have a heading: Card, Name, Category, Library. Sponsored-by: Athens County Public Libraries
Created attachment 182562 [details] [review] Bug 38127: Missing column headings in 'Add user' pop-up modal This patch modifies the template for adding to a basket from a new (empty) record in order to make the "Add user" patron search results correct. The patron search results table headers must be defined in the template before they are used. To test, apply the patch and go to Acquisitions. - Search for a vendor. - Add or create a basket for that vendor. - Click "Add to basket" and select "From a new (empty) record." - In the "New order" form, under the "Patrons" heading, click "Add user" - Search for patrons to add. - In the patron search results, each column should have a heading: Card, Name, Category, Library. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 182770 [details] [review] Bug 38127: Missing column headings in 'Add user' pop-up modal This patch modifies the template for adding to a basket from a new (empty) record in order to make the "Add user" patron search results correct. The patron search results table headers must be defined in the template before they are used. To test, apply the patch and go to Acquisitions. - Search for a vendor. - Add or create a basket for that vendor. - Click "Add to basket" and select "From a new (empty) record." - In the "New order" form, under the "Patrons" heading, click "Add user" - Search for patrons to add. - In the patron search results, each column should have a heading: Card, Name, Category, Library. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Nice work everyone! Pushed to main for 25.11
I see in 25.05.x
Pushed to 24.11.x for 24.11.06
Nice work everyone! Pushed to 25.05.x for 25.05.03