Bug 38129 - Add note regarding permissions in suggestion manager search pop-up modal
Summary: Add note regarding permissions in suggestion manager search pop-up modal
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: regression
Depends on: 35329
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-08 19:10 UTC by Caroline Cyr La Rose
Modified: 2024-10-11 10:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal (2.97 KB, patch)
2024-10-09 07:36 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal (3.03 KB, patch)
2024-10-09 12:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal (3.08 KB, patch)
2024-10-10 16:28 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-10-08 19:10:12 UTC
There used to be a note in the patron search pop-up for suggestion manager selection that "Only staff with superlibrarian or suggestions_manage permissions are returned in the search results". This note is no longer there.

To get there:
1. In the staff interface, go to More > Suggestions > New purchase suggestion
2. Click 'Select manager'
   --> Note that there is no note regarding the necessary permissions in the popup
3. Search for 'alford' (for example)
   --> There are no results because Jordan Alford doesn't have the necessary permissions

For comparison:
1. In the staff interface, go to Acquisitions
2. Click 'Search' next to the vendor search box
3. Click 'My Basket'
4. Click 'Add user'
   --> Note that there is a note "Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results"
Comment 1 Jonathan Druart 2024-10-09 07:36:37 UTC
Created attachment 172557 [details] [review]
Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal

1. In the staff interface, go to More > Suggestions > New purchase suggestion
2. Click 'Select manager'
=> With this patch you see a note regarding permissions
3. Search for 'alford' (for example)
=> User is not returned, they do not have the suggestion permission
Comment 2 Owen Leonard 2024-10-09 12:58:49 UTC
Created attachment 172571 [details] [review]
Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal

1. In the staff interface, go to More > Suggestions > New purchase
   suggestion
2. Click 'Select manager'
   => With this patch you see a note regarding permissions
3. Search for 'alford' (for example)
   => User is not returned, they do not have the suggestion permission

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Lucas Gass (lukeg) 2024-10-10 16:28:49 UTC
Created attachment 172665 [details] [review]
Bug 38129: Display note regarding permissions in suggestion manager search pop-up modal

1. In the staff interface, go to More > Suggestions > New purchase
   suggestion
2. Click 'Select manager'
   => With this patch you see a note regarding permissions
3. Search for 'alford' (for example)
   => User is not returned, they do not have the suggestion permission

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-10-11 10:28:03 UTC
Pushed for 24.11!

Well done everyone, thank you!