This should either be an authorised value or free text. Applicable to all views that allow booking cancelation.
Created attachment 173230 [details] [review] Bug 38222: Add combobox component Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173231 [details] [review] Bug 38222: Add cancellation reason to bookings patch definition; reformat bookings definition Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173232 [details] [review] Bug 38222: Add handling for cancellation reasons to cancel booking modal template, associated script Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173233 [details] [review] Bug 38222: Use comboboxes in circ/circulation.pl, bookings/list.pl, members/moremember.pl To test: 1) Apply dependencies and this patch 2) Maybe update class files w/ update_dbix_class_files.pl 3) Build a new bundle w/ yarn api:bundle 4) Restart plack 5) Add a couple bookings to a patron 6) Go to any of the above modules 7) Cancel the booking and note 7.1) That the value you input is correctly received by the backend for cancellation_reason 7.2) Do it for the other 2 modules 8) Configure some authorised values under category BOOKING_CANCELLATION 9) Repeat 7 and note that you can select them in the combobox 10) Sign off or leave your feedback Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Position: fixed behaves differently in Firefox vs Chrome. In chrome the options of the combobox float around in weird ways.
Created attachment 173264 [details] [review] Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this. Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173265 [details] [review] Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
I didn't check how we do this normally, but would it be preferable to write the AV to the db and then use the AuthorisedValues template plugin in the notice instead?
Created attachment 173277 [details] [review] Bug 38222: (follow-up) Remove residual inline styles from example for combobox usage Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173278 [details] [review] Bug 38222: (follow-up) Minimally initialize combobox if passed no data via constructor or referenced elements Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173281 [details] [review] Bug 38222: (follow-up) Only replace first numerical match in bookings count containers Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173282 [details] [review] Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Created attachment 173312 [details] [review] Bug 38222: Add combobox component Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173313 [details] [review] Bug 38222: Add cancellation reason to bookings patch definition; reformat bookings definition Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173314 [details] [review] Bug 38222: Add handling for cancellation reasons to cancel booking modal template, associated script Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173315 [details] [review] Bug 38222: Use comboboxes in circ/circulation.pl, bookings/list.pl, members/moremember.pl To test: 1) Apply dependencies and this patch 2) Maybe update class files w/ update_dbix_class_files.pl 3) Build a new bundle w/ yarn api:bundle 4) Restart plack 5) Add a couple bookings to a patron 6) Go to any of the above modules 7) Cancel the booking and note 7.1) That the value you input is correctly received by the backend for cancellation_reason 7.2) Do it for the other 2 modules 8) Configure some authorised values under category BOOKING_CANCELLATION 9) Repeat 7 and note that you can select them in the combobox 10) Sign off or leave your feedback Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173316 [details] [review] Bug 38222: (follow-up) Reset overflow property of modal-body to prevent clipping of combobox options instead of position: fixed Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this. Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173317 [details] [review] Bug 38222: (follow-up) Remove residual inline styles from example for combobox usage Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173318 [details] [review] Bug 38222: (follow-up) Minimally initialize combobox if passed no data via constructor or referenced elements Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173319 [details] [review] Bug 38222: (follow-up) Only replace first numerical match in bookings count containers Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173320 [details] [review] Bug 38222: (follow-up) Include cancellation reason in sample notice for booking cancellation Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173321 [details] [review] Bug 38222: (QA follow-up) Add av category update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Discussed with Paul.. we're going to add however text on the cancelled status containing the reason and he's going to move the js snippet that's cloned in a few places into the modal.js asset to dry out the code a little for more re-use :) Once that's done I reckon we're PQA here :)
Created attachment 173322 [details] [review] Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173323 [details] [review] Bug 38222: (QA follow-up) Show cancellation reason where applicable, appropriately handle statuses Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173336 [details] [review] Bug 38222: (QA follow-up) Limit combobox input in cancel booking modal to db field length Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173337 [details] [review] Bug 38222: (QA follow-up) DRY event listener setup for combobox resets on modal close Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173338 [details] [review] Bug 38222: (QA follow-up) Show cancellation reason where applicable, appropriately handle statuses Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173339 [details] [review] Bug 38222: (QA follow-up) Limit combobox input in cancel booking modal to db field length Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Please don't ignore these :) FAIL installer/data/mysql/atomicupdate/bug_38222.pl FAIL file permissions File must have the exec flag When I git mv the file, I still need to fix it.
1) Capitalization (fixed in follow-up) <label for="cancellation-reason" class="form-label">Cancellation Reason:</label> = Cancellation reason 2) Translations (fixed in follow-up) + return __("Expired"); Double underscore for JS in .js files. Single underscore for JS in .tt files (and .inc). 3) combobox.js (to consider) This almost looks like a library, maybe to avoid any confusion in the future a copyright statement/license would not hurt?
Pushed for 24.11! Well done everyone, thank you!
Dropping keyword.
Enhancement, no 24.05.x backport