If the user has suggestions manage permission the controls for deleting and archiving suggestions do not trigger the event handler they are supposed to. The click function is too specific: it should be attached to <a> and <button>
Created attachment 173738 [details] [review] Bug 38305: Can't delete or archive suggestions This patch corrects JS on the suggestions page so that the delete, archive, and unarchive controls work. The patch also modifies the markup of the "Delete" button so that it is consisten with other pages. To test, apply the patch and go to the suggestions page in the staff interface. - Log in to the staff interface as a user with "suggestions_manage" permission. - If necessary, create a few suggestions to test with. - From the table of suggestions, click the secondary menu on the "Edit" button for one of the suggestions. - Choose "Delete." You should get a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. - Choose "Archive." There won't be a confirmation, and the title should disappear from the list. - To test whether the suggestion was archived, search for it using the sidebar form, checking the "Include archived" checkbox. The suggestion should show up in the list with an "Archived" label. - Clicking the "Edit" secondary menu on the archived suggestion should trigger a menu with an "Unarchive" option. Click that and confirm that the suggestion is no longer archived. - Now log in as a user with only "suggestions_delete" permission but not "suggestions_manage" - In the list of suggestions each title should have a "delete" button. - Clicking the delete button should trigger a confirmation dialog. Both the "OK" and "Cancel" options should work as expected.
Created attachment 173834 [details] [review] Bug 38305: Can't delete or archive suggestions This patch corrects JS on the suggestions page so that the delete, archive, and unarchive controls work. The patch also modifies the markup of the "Delete" button so that it is consisten with other pages. To test, apply the patch and go to the suggestions page in the staff interface. - Log in to the staff interface as a user with "suggestions_manage" permission. - If necessary, create a few suggestions to test with. - From the table of suggestions, click the secondary menu on the "Edit" button for one of the suggestions. - Choose "Delete." You should get a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. - Choose "Archive." There won't be a confirmation, and the title should disappear from the list. - To test whether the suggestion was archived, search for it using the sidebar form, checking the "Include archived" checkbox. The suggestion should show up in the list with an "Archived" label. - Clicking the "Edit" secondary menu on the archived suggestion should trigger a menu with an "Unarchive" option. Click that and confirm that the suggestion is no longer archived. - Now log in as a user with only "suggestions_delete" permission but not "suggestions_manage" - In the list of suggestions each title should have a "delete" button. - Clicking the delete button should trigger a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Hi Owen! Thank you for this patch! There is a trivial issue I noticed, not related to your patch, that we should fix probably in another bug. In your test plan there is the step to "Choose "Delete." You should get a confirmation dialog. Both the "OK" and "Cancel" options should work as expected." Whenever "Cancel" is selected, it doesn't automatically close the secondary menu on "Edit". It keeps it open- at least on my end. In my experience the secondary menu typically closes out once a click is made on something else, such as by clicking "Cancel". Any-who this patch is great! Thanks!
Created attachment 173866 [details] [review] Bug 38305: Can't delete or archive suggestions This patch corrects JS on the suggestions page so that the delete, archive, and unarchive controls work. The patch also modifies the markup of the "Delete" button so that it is consisten with other pages. To test, apply the patch and go to the suggestions page in the staff interface. - Log in to the staff interface as a user with "suggestions_manage" permission. - If necessary, create a few suggestions to test with. - From the table of suggestions, click the secondary menu on the "Edit" button for one of the suggestions. - Choose "Delete." You should get a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. - Choose "Archive." There won't be a confirmation, and the title should disappear from the list. - To test whether the suggestion was archived, search for it using the sidebar form, checking the "Include archived" checkbox. The suggestion should show up in the list with an "Archived" label. - Clicking the "Edit" secondary menu on the archived suggestion should trigger a menu with an "Unarchive" option. Click that and confirm that the suggestion is no longer archived. - Now log in as a user with only "suggestions_delete" permission but not "suggestions_manage" - In the list of suggestions each title should have a "delete" button. - Clicking the delete button should trigger a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.11! Well done everyone, thank you!
Created attachment 173929 [details] [review] Bug 38305: Can't delete or archive suggestions This patch corrects JS on the suggestions page so that the delete, archive, and unarchive controls work. The patch also modifies the markup of the "Delete" button so that it is consisten with other pages. To test, apply the patch and go to the suggestions page in the staff interface. - Log in to the staff interface as a user with "suggestions_manage" permission. - If necessary, create a few suggestions to test with. - From the table of suggestions, click the secondary menu on the "Edit" button for one of the suggestions. - Choose "Delete." You should get a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. - Choose "Archive." There won't be a confirmation, and the title should disappear from the list. - To test whether the suggestion was archived, search for it using the sidebar form, checking the "Include archived" checkbox. The suggestion should show up in the list with an "Archived" label. - Clicking the "Edit" secondary menu on the archived suggestion should trigger a menu with an "Unarchive" option. Click that and confirm that the suggestion is no longer archived. - Now log in as a user with only "suggestions_delete" permission but not "suggestions_manage" - In the list of suggestions each title should have a "delete" button. - Clicking the delete button should trigger a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>