Following FIXME lines on ILL/Backend/Standard.pm: # FIXME: This should all be made translatable as is basically a # code => description mapping. The metadata() sub is using this # descriptions as keys. I thought this was a bug on this backend # but it turns out opac-illrequests.tt is using those descriptions # as keys. for example: # [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]...
Created attachment 180155 [details] [review] Bug 38339: Preparation: Access value of attribute by its key, not by display label This ensures the value of the intended attribute is displayed, regardless of its translatable description
Created attachment 180156 [details] [review] Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the OPAC ILL requests table: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 4) Notice both the title and author show. 5) Back on the Staff UI, enable es-ES for OPACLanguages and enable opaclanguagesdisplay 6) Repeat 3). Notice: - The title and author column headers are not translated to es-ES - The title and author data values are not displayed on the columns 7) Apply patches, restart plack and update es-ES installation: - koha-plack --restart kohadev - koha-translate --update es-ES --dev kohadev 8) Repeat 3). Notice the column headers are translated and the data is shown.
Created attachment 180176 [details] [review] Bug 38339: Preparation: Access value of attribute by its key, not by display label This ensures the value of the intended attribute is displayed, regardless of its translatable description
Created attachment 180177 [details] [review] Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the ILL request on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=view&illrequest_id=1 4) Activate es-ES language from the footer. Notice 'Title' and 'Author' still show as english 5) Apply patches. restart plack and update translation koha-plack --restart kohadev koha-translate --update es-ES --dev kohadev 6) Repeat 3). Notice those labels are now translated. 7) Ensure the table renders correctly and displays the data author and title data: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
Created attachment 180529 [details] [review] Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the ILL request on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=view&illrequest_id=1 4) Activate es-ES language from the footer. Notice 'Title' and 'Author' still show as english 5) Apply patches. restart plack and update translation koha-plack --restart kohadev koha-translate --update es-ES --dev kohadev 6) Repeat 3). Notice those labels are now translated. 7) Ensure the table renders correctly and displays the data author and title data: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl Signed-off-by: Magnus Enger <magnus@libriotech.no>
Marking this as duplicate of bug 39600 as the work done there implicitly fixes the issue described here. *** This bug has been marked as a duplicate of bug 39600 ***
Reopening this and leaving just the i18n patch, making it depend on bug 39600 for the reasons stated above.
Created attachment 181136 [details] [review] Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the ILL request on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=view&illrequest_id=1 4) Activate es-ES language from the footer. Notice 'Title' and 'Author' still show as english 5) Apply patches. restart plack and update translation koha-plack --restart kohadev koha-translate --update es-ES --dev kohadev 6) Repeat 3). Notice those labels are now translated. 7) Ensure the table renders correctly and displays the data author and title data: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Is this not breaking this line in the OPAC? <td> [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]<span>N/A</span>[% END %] </td> If we translate Author?
Tomas says this is fixed later on, so adding "additional_work_needed" as a reminder to check back on this once we got through the tree.
Pushed for 25.05! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #9) > Is this not breaking this line in the OPAC? > > <td> [% IF request.metadata.Author %][% request.metadata.Author | html %][% > ELSE %]<span>N/A</span>[% END %] </td> > > > If we translate Author? The line in question doesn't appear to exist anymore. Assuming fixed.