Bug 39444 - Standard form does not consider PubMed ID
Summary: Standard form does not consider PubMed ID
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on: 38339
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-25 10:17 UTC by Pedro Amorim
Modified: 2025-05-09 07:14 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39444: Make Standard consider pubmedid field (1.70 KB, patch)
2025-03-25 10:19 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 39444: Make Standard consider pubmedid field (1.75 KB, patch)
2025-04-07 16:42 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 39444: Make Standard consider pubmedid field (1.87 KB, patch)
2025-05-08 19:57 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-03-25 10:17:53 UTC

    
Comment 1 Pedro Amorim 2025-03-25 10:19:48 UTC
Created attachment 179678 [details] [review]
Bug 39444: Make Standard consider pubmedid field

This field may be added by a plugin or jQuery, so Standard should consider it as a possibility.
This patch does not change anything for existing users that do not add a 'pubmed id' field themselves.

1) Enable ILLModule
2) Install the ILL Actions plugin:
https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v2.0.1
3) Create a new ILL request:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
4) Pick type: 'Journal article', notice a top pop-up for DOI/PubMed ID now shows. This is coming from the plugin.
5) Add something to the pubmedid input like '123'. Notice the metadata is auto-filled.
6) Add a patron cardnumber '42'. Notice the library is automatically picked. Click 'Create'.
7) On the manage request screen, notice the PubMed ID is not shown. This is because it was not saved.
8) Apply patch and repeat.
Comment 2 PTFS Europe Sandboxes 2025-04-07 16:42:37 UTC
Created attachment 180702 [details] [review]
Bug 39444: Make Standard consider pubmedid field

This field may be added by a plugin or jQuery, so Standard should consider it as a possibility.
This patch does not change anything for existing users that do not add a 'pubmed id' field themselves.

1) Enable ILLModule
2) Install the ILL Actions plugin:
https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v2.0.1
3) Create a new ILL request:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
4) Pick type: 'Journal article', notice a top pop-up for DOI/PubMed ID now shows. This is coming from the plugin.
5) Add something to the pubmedid input like '123'. Notice the metadata is auto-filled.
6) Add a patron cardnumber '42'. Notice the library is automatically picked. Click 'Create'.
7) On the manage request screen, notice the PubMed ID is not shown. This is because it was not saved.
8) Apply patch and repeat.

Signed-off-by: Jeremy Evans <jeremy.evans@ukhsa.gov.uk>
Comment 3 Jeremy Evans 2025-04-07 16:44:20 UTC
Tested on a sandbox. It all works as described. Changing status to signed off.
Comment 4 Tomás Cohen Arazi (tcohen) 2025-05-08 19:57:40 UTC
Created attachment 182112 [details] [review]
Bug 39444: Make Standard consider pubmedid field

This field may be added by a plugin or jQuery, so Standard should consider it as a possibility.
This patch does not change anything for existing users that do not add a 'pubmed id' field themselves.

1) Enable ILLModule
2) Install the ILL Actions plugin:
https://github.com/PTFS-Europe/koha-plugin-ill-actions/releases/tag/v2.0.1
3) Create a new ILL request:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
4) Pick type: 'Journal article', notice a top pop-up for DOI/PubMed ID now shows. This is coming from the plugin.
5) Add something to the pubmedid input like '123'. Notice the metadata is auto-filled.
6) Add a patron cardnumber '42'. Notice the library is automatically picked. Click 'Create'.
7) On the manage request screen, notice the PubMed ID is not shown. This is because it was not saved.
8) Apply patch and repeat.

Signed-off-by: Jeremy Evans <jeremy.evans@ukhsa.gov.uk>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit (tcohen): adapted to 38339
Comment 5 Katrin Fischer 2025-05-09 07:14:05 UTC
Pushed for 25.05!

Well done everyone, thank you!