Bug 38362 - Printing lists only prints the ten first results in the OPAC
Summary: Printing lists only prints the ten first results in the OPAC
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-05 22:12 UTC by Lucas Gass (lukeg)
Modified: 2025-02-03 16:14 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes printing lists in the OPAC so that all the items are printed, instead of only the first 10.
Version(s) released in:
25.05.00,24.11.01,24.05.06,23.11.11
Circulation function:


Attachments
Bug 38362: Fix printing lists on opac/opac-shelves.pl (1.24 KB, patch)
2024-11-05 22:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38362: Fix printing lists on opac/opac-shelves.pl (1.30 KB, patch)
2024-11-05 23:13 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 38362: Fix printing lists on opac/opac-shelves.pl (1.43 KB, patch)
2024-11-22 09:33 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-11-05 22:12:30 UTC
Bug 37285 but for the OPAC. It looks like we can take what was done there ( virtualshelves/shelves.pl ) and apply it the OPAC ( opac/opac-shelves.pl ).
Comment 1 Lucas Gass (lukeg) 2024-11-05 22:15:00 UTC
Created attachment 174049 [details] [review]
Bug 38362: Fix printing lists on opac/opac-shelves.pl

To test from the OPAC:
1 - create a list with more than 10 items
2 - print the list -> there is a pagination and that only 10 items
  are printed
3 - Apply patch
4 - print the list again -> every items are being printed
Comment 2 Biblibre Sandboxes 2024-11-05 23:13:00 UTC
Created attachment 174050 [details] [review]
Bug 38362: Fix printing lists on opac/opac-shelves.pl

To test from the OPAC:
1 - create a list with more than 10 items
2 - print the list -> there is a pagination and that only 10 items
  are printed
3 - Apply patch
4 - print the list again -> every items are being printed

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 Marcel de Rooy 2024-11-22 09:33:45 UTC
Created attachment 174916 [details] [review]
Bug 38362: Fix printing lists on opac/opac-shelves.pl

To test from the OPAC:
1 - create a list with more than 10 items
2 - print the list -> there is a pagination and that only 10 items
  are printed
3 - Apply patch
4 - print the list again -> every items are being printed

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT] Tidied: added a few spaces.
Comment 4 Katrin Fischer 2024-12-03 14:55:50 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2024-12-12 11:55:36 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 6 Wainui Witika-Park 2024-12-17 01:32:36 UTC
Backported to 24.05.x for 24.05.06
Comment 7 Fridolin Somers 2024-12-18 15:37:27 UTC
Pushed to 23.11.x for 23.11.11
Comment 8 Jesse Maseto 2025-02-03 16:14:56 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.