Bug 38444 - Bug 34147 follow-up: add tests
Summary: Bug 34147 follow-up: add tests
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 34147
Blocks:
  Show dependency treegraph
 
Reported: 2024-11-14 13:38 UTC by Nick Clemens (kidclamp)
Modified: 2024-12-11 18:04 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 38444: Unit test to ensure limited categories don't break display (3.03 KB, patch)
2024-11-14 13:40 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 38444: Unit test to ensure limited categories don't break display (3.10 KB, patch)
2024-11-15 13:10 UTC, David Nind
Details | Diff | Splinter Review
Bug 38444: Unit test to ensure limited categories don't break display (3.15 KB, patch)
2024-11-21 22:57 UTC, David Cook
Details | Diff | Splinter Review
Bug 38444: (QA follow-up) tidy (2.80 KB, patch)
2024-11-21 22:57 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-11-14 13:38:52 UTC

    
Comment 1 Nick Clemens (kidclamp) 2024-11-14 13:40:15 UTC
Created attachment 174527 [details] [review]
Bug 38444: Unit test to ensure limited categories don't break display
Comment 2 David Nind 2024-11-15 13:10:57 UTC
Created attachment 174576 [details] [review]
Bug 38444: Unit test to ensure limited categories don't break display

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-11-15 13:11:23 UTC
Testing notes (using KTD):

1. Start up KTD with selenium: ktd --selenium up
2. Run the tests: prove t/db_dependent/selenium/patrons_search.t
3. Apply the patch.
4. Repeat step 2, tests should continue to pass.
Comment 4 David Cook 2024-11-21 22:57:40 UTC
Created attachment 174905 [details] [review]
Bug 38444: Unit test to ensure limited categories don't break display

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 David Cook 2024-11-21 22:57:42 UTC
Created attachment 174906 [details] [review]
Bug 38444: (QA follow-up) tidy

Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 6 Katrin Fischer 2024-11-22 09:23:45 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 David Nind 2024-12-11 18:04:05 UTC
This adds tests, no updates to the manual required.