Created attachment 175045 [details] [review] Bug 38594: Fix table settings on the course reserves tables - OPAC We are passing the columns settings, but KohaTable is expecting the table settings. Test plan: Hide some columns for the course reserves table at the OPAC Define a course, add 1+ items Go to the OPAC, "Course reserves" Notice that with this patch the columns are correctly hidden by default.
Created attachment 175046 [details] [review] Bug 38594: Remove unused TablesSettings.GetColumns This is no longer used, and should not. Test plan: git grep TablesSettings.GetColumns should not return any results git grep GetColumns should not return results related to this method
Created attachment 175055 [details] [review] Bug 38594: Fix table settings on the course reserves tables - OPAC We are passing the columns settings, but KohaTable is expecting the table settings. Test plan: Hide some columns for the course reserves table at the OPAC Define a course, add 1+ items Go to the OPAC, "Course reserves" Notice that with this patch the columns are correctly hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 175056 [details] [review] Bug 38594: Remove unused TablesSettings.GetColumns This is no longer used, and should not. Test plan: git grep TablesSettings.GetColumns should not return any results git grep GetColumns should not return results related to this method Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 175060 [details] [review] Bug 38594: Fix table settings on the course reserves tables - OPAC We are passing the columns settings, but KohaTable is expecting the table settings. Test plan: Hide some columns for the course reserves table at the OPAC Define a course, add 1+ items Go to the OPAC, "Course reserves" Notice that with this patch the columns are correctly hidden by default. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 175061 [details] [review] Bug 38594: Remove unused TablesSettings.GetColumns This is no longer used, and should not. Test plan: git grep TablesSettings.GetColumns should not return any results git grep GetColumns should not return results related to this method Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.01
Could I please get a more detailed test plan for 24.05.x? :)
(In reply to Wainui Witika-Park from comment #9) > Could I please get a more detailed test plan for 24.05.x? :) You can ignore the second patch as it is only removing dead code (and maybe not dead in 24.05.x, I have not confirmed that). For the first patch try the following steps: Go to the Table settings administration page, under the "OPAC" tab you have the configuration for the course_items table (http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#course_items) Tick Title to make it hidden by default. Define a course and add at least one item At the OPAC, under "Course reserves" you should see the table with the column hidden by default. Without this patch the column is not hidden (ie. the settings are not taken into account)
(In reply to Jonathan Druart from comment #10) > (In reply to Wainui Witika-Park from comment #9) > > Could I please get a more detailed test plan for 24.05.x? :) > > You can ignore the second patch as it is only removing dead code (and maybe > not dead in 24.05.x, I have not confirmed that). > > For the first patch try the following steps: > > Go to the Table settings administration page, under the "OPAC" tab you have > the configuration for the course_items table > (http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#course_items) > Tick Title to make it hidden by default. > Define a course and add at least one item > At the OPAC, under "Course reserves" you should see the table with the > column hidden by default. > > Without this patch the column is not hidden (ie. the settings are not taken > into account) Thanks Jonathan! Unfortunately the columns are still not being hidden correctly by the settings.
Not backporting to 24.05.x