To recreate: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one.
Bug 38183 didn't create the problem but it didn't help fix it either.
Created attachment 175339 [details] [review] Bug 38659: Fix select_manager function when there are no tabs To test: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. 6. APPLY PATCH 7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. 8. Go through the test plan on Bug 38659.
Created attachment 175346 [details] [review] Bug 38659: Fix select_manager function when there are no tabs To test: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. 6. APPLY PATCH 7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. 8. Go through the test plan on Bug 38183. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
*** Bug 38539 has been marked as a duplicate of this bug. ***
Created attachment 175568 [details] [review] Bug 38659: Fix select_manager function when there are no tabs To test: 1. Have multiple staff you have permissions to be a purchase suggestion manager. 2. Make some suggestions. 3. Edit a suggestion, go down to 'Select manager'. 4. Select a new manager, notice the new one name is not populated. 5. Save the record, the manager is not changed to the new one. 6. APPLY PATCH 7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion. 8. Go through the test plan on Bug 38183. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 25.05! Well done everyone, thank you!
Can this patch be backported to 24.11?
My staff would love it if this could be backported to 24.11. Or could this patch be applied to my Koha now?
(In reply to Sheri Waite from comment #8) > My staff would love it if this could be backported to 24.11. Or could this > patch be applied to my Koha now? Bug fixes are usually backported, but it's always good to know that there is interest for the RMaint when thy make the final decision.
Nice work everyone! Pushed to 24.11.x for 24.11.01
Hi Lucas, When I cherry-pick this patch from 24.11.x to 24.05.x it conflicts (see below): --- kohadev-koha@kohadevbox:koha(24.05.x)$ git cherry-pick 65c1d6ccf8d76e919db2fb18977e4299dbb297b2 Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt error: could not apply 65c1d6ccf8d... Bug 38659: Fix select_manager function when there are no tabs hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ git status On branch 24.05.x You are currently cherry-picking commit 65c1d6ccf8d. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Unmerged paths: (use "git add <file>..." to mark resolution) both modified: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Untracked files: --- Could you please attach a 24.05.x patch to this bug report? Thanks in advance, Alex
Not backporting to 24.05.x unless requested