Bug 38659 - Cannot set a new suggestion manager when editing a suggestion
Summary: Cannot set a new suggestion manager when editing a suggestion
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
: 38539 (view as bug list)
Depends on: 38183
Blocks:
  Show dependency treegraph
 
Reported: 2024-12-09 21:59 UTC by Lucas Gass (lukeg)
Modified: 2025-04-04 02:24 UTC (History)
10 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes editing suggestions so that you can change the suggestion manager in the staff interface. Previously, you could select a new suggestion manager, but the managed by field wasn't updated or saved.
Version(s) released in:
25.05.00,24.11.02
Circulation function:


Attachments
Bug 38659: Fix select_manager function when there are no tabs (1.87 KB, patch)
2024-12-09 22:04 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38659: Fix select_manager function when there are no tabs (1.92 KB, patch)
2024-12-10 12:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38659: Fix select_manager function when there are no tabs (1.99 KB, patch)
2024-12-16 19:02 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-12-09 21:59:05 UTC
To recreate:

1. Have multiple staff you have permissions to be a purchase suggestion manager. 
2. Make some suggestions.
3. Edit a suggestion, go down to 'Select manager'.
4. Select a new manager, notice the new one name is not populated.
5. Save the record, the manager is not changed to the new one.
Comment 1 Lucas Gass (lukeg) 2024-12-09 22:00:45 UTC
Bug 38183 didn't create the problem but it didn't help fix it either.
Comment 2 Lucas Gass (lukeg) 2024-12-09 22:04:19 UTC
Created attachment 175339 [details] [review]
Bug 38659: Fix select_manager function when there are no tabs

To test:
1. Have multiple staff you have permissions to be a purchase suggestion manager.
2. Make some suggestions.
3. Edit a suggestion, go down to 'Select manager'.
4. Select a new manager, notice the new one name is not populated.
5. Save the record, the manager is not changed to the new one.
6. APPLY PATCH
7. Try again steps 3-6, but this time the manager field should populate and the new manager should be saved when you save the suggestion.
8. Go through the test plan on Bug 38659.
Comment 3 Owen Leonard 2024-12-10 12:05:54 UTC
Created attachment 175346 [details] [review]
Bug 38659: Fix select_manager function when there are no tabs

To test:
1. Have multiple staff you have permissions to be a purchase suggestion
   manager.
2. Make some suggestions.
3. Edit a suggestion, go down to 'Select manager'.
4. Select a new manager, notice the new one name is not populated.
5. Save the record, the manager is not changed to the new one.
6. APPLY PATCH
7. Try again steps 3-6, but this time the manager field should populate
   and the new manager should be saved when you save the suggestion.
8. Go through the test plan on Bug 38183.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Lucas Gass (lukeg) 2024-12-11 22:45:40 UTC
*** Bug 38539 has been marked as a duplicate of this bug. ***
Comment 5 Martin Renvoize (ashimema) 2024-12-16 19:02:41 UTC
Created attachment 175568 [details] [review]
Bug 38659: Fix select_manager function when there are no tabs

To test:
1. Have multiple staff you have permissions to be a purchase suggestion
   manager.
2. Make some suggestions.
3. Edit a suggestion, go down to 'Select manager'.
4. Select a new manager, notice the new one name is not populated.
5. Save the record, the manager is not changed to the new one.
6. APPLY PATCH
7. Try again steps 3-6, but this time the manager field should populate
   and the new manager should be saved when you save the suggestion.
8. Go through the test plan on Bug 38183.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Katrin Fischer 2024-12-23 08:38:29 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 7 Laura O'Neil 2025-01-02 16:16:46 UTC
Can this patch be backported to 24.11?
Comment 8 Sheri Waite 2025-01-21 16:40:54 UTC
My staff would love it if this could be backported to 24.11. Or could this patch be applied to my Koha now?
Comment 9 Katrin Fischer 2025-01-21 16:58:40 UTC
(In reply to Sheri Waite from comment #8)
> My staff would love it if this could be backported to 24.11. Or could this
> patch be applied to my Koha now?

Bug fixes are usually backported, but it's always good to know that there is interest for the RMaint when thy make the final decision.
Comment 10 Paul Derscheid 2025-02-03 19:09:36 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 11 Alex Buckley 2025-03-20 03:28:15 UTC
Hi Lucas, 

When I cherry-pick this patch from 24.11.x to 24.05.x it conflicts (see below):

---

kohadev-koha@kohadevbox:koha(24.05.x)$ git cherry-pick 65c1d6ccf8d76e919db2fb18977e4299dbb297b2
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
error: could not apply 65c1d6ccf8d... Bug 38659: Fix select_manager function when there are no tabs
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ git status
On branch 24.05.x
You are currently cherry-picking commit 65c1d6ccf8d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt

Untracked files:

---

Could you please attach a 24.05.x patch to this bug report?

Thanks in advance,
Alex
Comment 12 Wainui Witika-Park 2025-04-04 02:24:36 UTC
Not backporting to 24.05.x unless requested