Bug 38718 - main container wrapper
Summary: main container wrapper
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 38714
Blocks: 38664
  Show dependency treegraph
 
Reported: 2024-12-17 07:56 UTC by Jonathan Druart
Modified: 2025-01-31 19:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38718: (follow-up) Wrap both search form and search results in wrapper (2.03 KB, patch)
2025-01-31 19:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38718: (follow-up) Use main-container.inc on ILL requests page (9.75 KB, patch)
2025-01-31 19:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38718: (follow-up) Restore sidebar menu to point of sale page (849 bytes, patch)
2025-01-31 19:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38718: (follow-up) Correct aside parameter (944 bytes, patch)
2025-01-31 19:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 38718: (follow-up) Use container wrapper on tags page (8.08 KB, patch)
2025-01-31 19:08 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-12-17 07:56:21 UTC
On bug 38664 we are going to tidy the template file and so indent them properly.

Most of our templates have the following structure:

<div class="main container-fluid">
    <div class="row">
        <div class="col-md-10 order-md-2 order-sm-1">
            <main>
                [% INCLUDE 'messages.inc' %]
                <!-- The content -->
            </main>
        </div>
        <div class="col-md-2 order-sm-2 order-md-1">
            <aside>
            </aside>
        </div>
    </div>
</div>

It would be useful to have a WRAPPER to avoid:
* errors (sometimes we see the two divs with the same order: sm-2)
* inconsistencies
* 4 indentation blocks (will be replaced with a single one)
Comment 1 Jonathan Druart 2024-12-17 08:11:42 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2024-12-17 08:37:19 UTC
This is how it would look like: https://gitlab.com/joubu/Koha/-/commit/360a3811f3194b762028c3a927c81f14322d6f38
Comment 3 Jonathan Druart 2025-01-21 08:46:51 UTC
This is ready for testing, use the commits from the branch of bug 38664.
Comment 4 Owen Leonard 2025-01-31 19:08:29 UTC
Created attachment 177403 [details] [review]
Bug 38718: (follow-up) Wrap both search form and search results in wrapper

Also pass "wide_full" parameter to main-container.inc
Comment 5 Owen Leonard 2025-01-31 19:08:32 UTC
Created attachment 177404 [details] [review]
Bug 38718: (follow-up) Use main-container.inc on ILL requests page
Comment 6 Owen Leonard 2025-01-31 19:08:34 UTC
Created attachment 177405 [details] [review]
Bug 38718: (follow-up) Restore sidebar menu to point of sale page
Comment 7 Owen Leonard 2025-01-31 19:08:36 UTC
Created attachment 177406 [details] [review]
Bug 38718: (follow-up) Correct aside parameter
Comment 8 Owen Leonard 2025-01-31 19:08:38 UTC
Created attachment 177407 [details] [review]
Bug 38718: (follow-up) Use container wrapper on tags page