Bug 38748 - Library name is missing in return to home transfer slip
Summary: Library name is missing in return to home transfer slip
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Emily Lamancusa (emlam)
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 36114
  Show dependency treegraph
 
Reported: 2024-12-18 20:51 UTC by Emily Lamancusa (emlam)
Modified: 2024-12-27 17:34 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the generation of the transfer slip - the library to transfer an item to is now shown, instead of being blank.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38748: Pass the correct branchcode value to transfer slip (2.38 KB, patch)
2024-12-18 20:58 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 38748: Pass the correct branchcode value to transfer slip (2.43 KB, patch)
2024-12-22 22:15 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2024-12-18 20:51:06 UTC

    
Comment 1 Emily Lamancusa (emlam) 2024-12-18 20:58:07 UTC
Created attachment 175678 [details] [review]
Bug 38748: Pass the correct branchcode value to transfer slip

To test:
1. Find or create an item belonging to a library other than the
   logged-in library
2. Check the item in and print slip
--> The transfer slip says "Transfer to" but the library name is blank
3. Apply patch and restart_all
4. Cancel the transfer or find a different item
5. Check the item in and print slip
--> The library name now appears on the slip
Comment 2 Emily Lamancusa (emlam) 2024-12-18 21:00:35 UTC
Note: Until bug 38588 is fixed, printing the transfer slip will cause an internal server error. However, the slip itself will still appear and the two behaviors are not related, so this bug can still be tested.
Comment 3 David Nind 2024-12-22 22:15:06 UTC
Created attachment 175906 [details] [review]
Bug 38748: Pass the correct branchcode value to transfer slip

To test:
1. Find or create an item belonging to a library other than the
   logged-in library
2. Check the item in and print slip
--> The transfer slip says "Transfer to" but the library name is blank
3. Apply patch and restart_all
4. Cancel the transfer or find a different item
5. Check the item in and print slip
--> The library name now appears on the slip

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2024-12-27 15:28:46 UTC
QA by RM
Comment 5 Katrin Fischer 2024-12-27 16:36:53 UTC
Pushed for 25.05!

Well done everyone, thank you!