Bug 38790 - Add HTML classes to item information fields for a record - item page (moredetail.pl)
Summary: Add HTML classes to item information fields for a record - item page (moredet...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Andrew Fuerste-Henry
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-27 17:35 UTC by Andrew Fuerste-Henry
Modified: 2025-01-10 03:17 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds CSS classes to each field on the record's item page. This makes it easier to customize the page, for example, hiding the "Paid for?" field. Field name: class name ---------------------- Record information: - Biblionumber: biblionumber - Item type: itemtype - Rental charge: rentalcharge - Daily rental charge: rentlcharge_daily - Hourly rental charge: rentalcharge_hourly - ISBN: isbn - Publication details: publication_details - Volume: volume - Physical details: physical_details - Notes: biblio_note - No. of items: item_count Item information: - Home library: homebranch - Item type: itype - Collection: ccode - Item call number: itemcallnumber - Copy number: copynumber - Shelving location: location - Replacement price: replacementprice - Materials specified: materials Statuses: - Current library: holdingbranch - Current renewals: renewals_count - Lost status: lost - Damaged status: damaged - Withdrawn status: withdrawn Priority: - Exclude from local holds priority: local_holds_priority - Bookable: bookable History: - Order date: order_info - Accession date: dateaccessioned - Invoice number: invoice - Total checkouts: issues - Last seen: datelastseen - Last borrowed: datelastborrowed - Last borrower: previous_borrowers - Paid for?: paidfor - Serial enumeration: enumchron - Public note: itemnotes - Non-public note: itemnotes_nonpublic
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 38790: Add classes to item information on moredetail.pl (18.52 KB, patch)
2024-12-27 19:06 UTC, Andrew Fuerste-Henry 		Details | Diff | Splinter Review
Bug 38790: Add classes to item information on moredetail.pl (18.57 KB, patch)
2024-12-30 02:41 UTC, David Nind 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-12-27 17:35:27 UTC 
The various bits of data on moredetail.pl don't have clear and distinct classes, so they're hard to adjust or hide. We should add some classes to make customization easier.

For example, a library may wish to hide the Paid For message on an item.
Comment 1 Andrew Fuerste-Henry 2024-12-27 19:06:14 UTC 
Created attachment 175963 [details] [review]
Bug 38790: Add classes to item information on moredetail.pl

to test:
1 - Have a bib with multiple items
2 - view those items on the Items tab (moredetail.pl), confirm various parts of the page are not classed and are therefore hard to target with CSS, etc
3 - apply patch
4 - reload page, observe there are classes on things but the display and data have not changed
Comment 2 David Nind 2024-12-30 02:41:44 UTC 
Created attachment 175977 [details] [review]
Bug 38790: Add classes to item information on moredetail.pl

to test:
1 - Have a bib with multiple items
2 - view those items on the Items tab (moredetail.pl), confirm various parts of the page are not classed and are therefore hard to target with CSS, etc
3 - apply patch
4 - reload page, observe there are classes on things but the display and data have not changed

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-12-30 02:44:02 UTC 
Have added related bug 7508.

Not sure if these two bugs will work together.

(Also added the assignee 8-).)
Comment 4 Katrin Fischer 2024-12-30 13:46:41 UTC 
Fixed class="rentlcharge_daily" within the original patch.

I see that the classes are named like the fields in the database, which leads to a bit of a clash with terminology guidelines. But I can see consistency in that so I will leave it.
Comment 5 Katrin Fischer 2024-12-30 14:15:02 UTC 
Pushed for 25.05!

Well done everyone, thank you!