Currently, the 'Switch provider' option lists all other installed backends and forces the user to pick one. If AutoILLBackendPriority is enabled, this action should make use of it, i.e. present the automatic backend screen, query all installed backends for availability and suggest the most appropriate one.
Created attachment 176121 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds.
Created attachment 176122 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles
Created attachment 176123 [details] [review] Bug 38819: 'Return to form' vs 'return to request'
Created attachment 176139 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176140 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176141 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but just a question. The "Switch provider" option disappeared for the ILL request once it switched to PluginBackend. Is that what should be expected? Testing notes (using KTD): 1. Apply the patches (and all the dependencies). 2. Update the database: updatedatabase 3. Restart everything: restart_all
(In reply to David Nind from comment #7) > I've signed off, but just a question. > > The "Switch provider" option disappeared for the ILL request once it > switched to PluginBackend. Is that what should be expected? > > Testing notes (using KTD): > 1. Apply the patches (and all the dependencies). > 2. Update the database: updatedatabase > 3. Restart everything: restart_all Thank you for testing and sign-off, David! =D I can't reproduce that, the 'switch provider' option always shows for me following the test plan again. The installed plugin must be release v2.0.6, are you able to double-check if that is the release you're using? Thanks!
(In reply to Pedro Amorim from comment #8) > (In reply to David Nind from comment #7) > > I've signed off, but just a question. > > > > The "Switch provider" option disappeared for the ILL request once it > > switched to PluginBackend. Is that what should be expected? > > > > Testing notes (using KTD): > > 1. Apply the patches (and all the dependencies). > > 2. Update the database: updatedatabase > > 3. Restart everything: restart_all > > Thank you for testing and sign-off, David! =D > I can't reproduce that, the 'switch provider' option always shows for me > following the test plan again. The installed plugin must be release v2.0.6, > are you able to double-check if that is the release you're using? Thanks! You are right! Looks like I used the wrong version of the plugin. I retested, and everything works as expected + the "Switch provider" is available irrespective of the provider.
Created attachment 176519 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176520 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176521 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176575 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t