Currently, the 'Switch provider' option lists all other installed backends and forces the user to pick one. If AutoILLBackendPriority is enabled, this action should make use of it, i.e. present the automatic backend screen, query all installed backends for availability and suggest the most appropriate one.
Created attachment 176121 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds.
Created attachment 176122 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles
Created attachment 176123 [details] [review] Bug 38819: 'Return to form' vs 'return to request'
Created attachment 176139 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176140 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176141 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
I've signed off, but just a question. The "Switch provider" option disappeared for the ILL request once it switched to PluginBackend. Is that what should be expected? Testing notes (using KTD): 1. Apply the patches (and all the dependencies). 2. Update the database: updatedatabase 3. Restart everything: restart_all
(In reply to David Nind from comment #7) > I've signed off, but just a question. > > The "Switch provider" option disappeared for the ILL request once it > switched to PluginBackend. Is that what should be expected? > > Testing notes (using KTD): > 1. Apply the patches (and all the dependencies). > 2. Update the database: updatedatabase > 3. Restart everything: restart_all Thank you for testing and sign-off, David! =D I can't reproduce that, the 'switch provider' option always shows for me following the test plan again. The installed plugin must be release v2.0.6, are you able to double-check if that is the release you're using? Thanks!
(In reply to Pedro Amorim from comment #8) > (In reply to David Nind from comment #7) > > I've signed off, but just a question. > > > > The "Switch provider" option disappeared for the ILL request once it > > switched to PluginBackend. Is that what should be expected? > > > > Testing notes (using KTD): > > 1. Apply the patches (and all the dependencies). > > 2. Update the database: updatedatabase > > 3. Restart everything: restart_all > > Thank you for testing and sign-off, David! =D > I can't reproduce that, the 'switch provider' option always shows for me > following the test plan again. The installed plugin must be release v2.0.6, > are you able to double-check if that is the release you're using? Thanks! You are right! Looks like I used the wrong version of the plugin. I retested, and everything works as expected + the "Switch provider" is available irrespective of the provider.
Created attachment 176519 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176520 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176521 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176575 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t
Somewhere in the process with all dependencies in PQA, this does not apply
Created attachment 179733 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179734 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179735 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179736 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t
Rebased for main (on top of tidied bug 38669)
Created attachment 179754 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179755 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179756 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179757 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t
Created attachment 179759 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179760 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179761 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 179762 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t
Created attachment 180340 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180341 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180345 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180346 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180349 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180351 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180353 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180367 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180390 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180391 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180392 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180393 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t
`ill-requests.tt` has some stray merge markers. Please fix.
Created attachment 180509 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180510 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180511 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 180512 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t
(In reply to Tomás Cohen Arazi (tcohen) from comment #40) > `ill-requests.tt` has some stray merge markers. Please fix. Thanks for spotting that! Fixed and reran qa script, all happy. Changed to PQA as discussed. Thank you!
Created attachment 180514 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 180515 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 180516 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 180517 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Hi Pedro, can you please rebase on latest main? Hope I didn't miss a dependency? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38819: Auto migrate controller logic Applying: Bug 38819: Auto switch: Breadcrumbs+header titles error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38819: Auto switch: Breadcrumbs+header titles hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-38819-Auto-switch-Breadcrumbsheader-titles-qzi0v8nr.patch
Created attachment 181348 [details] [review] Bug 38819: Auto migrate controller logic Test plan, k-t-d: 0) Install the 'PluginBackend' plugin: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.6 1) Enable ILLModule syspref and check the "PluginBackend" backend in AutoILLBackendPriority: http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Create a new 'auto' ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Select type 'journal article', add '123' as DOI, '42' as cardnumber and any library 4) You should be on the automatic backend screen. The PluginBackend has a 50% chance to return available, so this step may suggest PluginBackend or Standard. Pick whatever was suggested. Click 'confirm'. 5) You are now on the request detail page. Click "Switch provider". You should be back on the automatic backend screen. Repeat this step as many times needed to switch from Standard <-> PluginBackend multiple times. Ensure it always succeeds. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 181349 [details] [review] Bug 38819: Auto switch: Breadcrumbs+header titles Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 181350 [details] [review] Bug 38819: 'Return to form' vs 'return to request' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 181351 [details] [review] Bug 38819: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Looks like a slight rebase on top of bug 38685 was required. I must've forgotten to set this dependency. Apologies.
+ <span>Confirm switch provider</span> Just wondering if we might want to switch to "Confirm switching provider" or "Confirm provider switch" (I am not a native speaker, so happy to be told I am talking nonsense :) )
Pushed for 25.05! Well done everyone, thank you!
(In reply to Katrin Fischer from comment #56) > + <span>Confirm switch provider</span> > > Just wondering if we might want to switch to "Confirm switching provider" or > "Confirm provider switch" (I am not a native speaker, so happy to be told I > am talking nonsense :) ) Fair, I agree. Though the button clicked to visit the page is labeled "Switch provider", for that reason I think it makes sense to use those 2 words exactly. "Switch provider confirmation"? Or just simply "Switch provider" as this is the page header+breadcrumbs and the "confirm/confirmation" part may be redundant.
(In reply to Pedro Amorim from comment #58) > (In reply to Katrin Fischer from comment #56) > > + <span>Confirm switch provider</span> > > > > Just wondering if we might want to switch to "Confirm switching provider" or > > "Confirm provider switch" (I am not a native speaker, so happy to be told I > > am talking nonsense :) ) > > Fair, I agree. Though the button clicked to visit the page is labeled > "Switch provider", for that reason I think it makes sense to use those 2 > words exactly. "Switch provider confirmation"? Or just simply "Switch > provider" as this is the page header+breadcrumbs and the > "confirm/confirmation" part may be redundant. We can still do that later - I think we have some existing patterns in the administration module for deleting things.
Dropping the question about string change - as noted earlier, we can deal with that later/separately if needed.