Bug 39462 - (bug 37870 follow-up) Default values from framework are inserted into existing record while editing
Summary: (bug 37870 follow-up) Default values from framework are inserted into existin...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major
Assignee: Janusz Kaczmarek
QA Contact: Testopia
URL:
Keywords:
Depends on: 37870
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-26 17:32 UTC by Janusz Kaczmarek
Modified: 2025-03-26 18:51 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing (2.04 KB, patch)
2025-03-26 17:41 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 39462: Unit tests (1.12 KB, patch)
2025-03-26 17:41 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing (2.10 KB, patch)
2025-03-26 18:51 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 39462: Unit tests (1.17 KB, patch)
2025-03-26 18:51 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2025-03-26 17:32:23 UTC
Due to changes made by the commit 0472b56a671, when editing an existing bibliographic record a default value is inserted while it should not, according to ApplyFrameworkDefaults systempreference.
Comment 1 Janusz Kaczmarek 2025-03-26 17:41:20 UTC
Created attachment 179742 [details] [review]
Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing

Due to changes made by the commit 0472b56a671, when editing an
existing bibliographic record a default value is inserted while it
should not, according to ApplyFrameworkDefaults systempreference.

Test plan:
==========
1. Verify that ApplyFrameworkDefaults systempreference is set to
   ‘when cataloguing new records only’.
2. Take any existing bibliographic record, e.g. sn:1. Open it in
   standard editor and identify a non used (empty) subfield, e.g. 024 $a.
   Note the framework (Books, Booklets, Workbooks). Close the editor
   (Cancel).
3. Modify the framework in question (Books, Booklets, Workbooks) by
   setting a default value for the chosen subfield (e.g. 024 $a).
4. Open the record in the editor again. Note that the 024 $a subfield
   has now an inserted default value while it should not, according to
   the ApplyFrameworkDefaults setting. Do not save the record, chose
   Cancel.
5. Apply the patch ; restart_all.
6. Repeat p. 4 -- there should be no default value inserted in the
   existing record now.

Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum)
Comment 2 Janusz Kaczmarek 2025-03-26 17:41:23 UTC
Created attachment 179743 [details] [review]
Bug 39462: Unit tests
Comment 3 Roman Dolny 2025-03-26 18:51:24 UTC
Created attachment 179744 [details] [review]
Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing

Due to changes made by the commit 0472b56a671, when editing an
existing bibliographic record a default value is inserted while it
should not, according to ApplyFrameworkDefaults systempreference.

Test plan:
==========
1. Verify that ApplyFrameworkDefaults systempreference is set to
   ‘when cataloguing new records only’.
2. Take any existing bibliographic record, e.g. sn:1. Open it in
   standard editor and identify a non used (empty) subfield, e.g. 024 $a.
   Note the framework (Books, Booklets, Workbooks). Close the editor
   (Cancel).
3. Modify the framework in question (Books, Booklets, Workbooks) by
   setting a default value for the chosen subfield (e.g. 024 $a).
4. Open the record in the editor again. Note that the 024 $a subfield
   has now an inserted default value while it should not, according to
   the ApplyFrameworkDefaults setting. Do not save the record, chose
   Cancel.
5. Apply the patch ; restart_all.
6. Repeat p. 4 -- there should be no default value inserted in the
   existing record now.

Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum)
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Roman Dolny 2025-03-26 18:51:26 UTC
Created attachment 179745 [details] [review]
Bug 39462: Unit tests

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>